From d37955578412848395f2a7c8ac0ae570634cdd14 Mon Sep 17 00:00:00 2001 From: Paul Chote Date: Sat, 19 Jan 2019 19:15:26 +0000 Subject: [PATCH] Remove Game.Debug messages from ValidateOrder. --- OpenRA.Mods.Common/Traits/World/ValidateOrder.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/OpenRA.Mods.Common/Traits/World/ValidateOrder.cs b/OpenRA.Mods.Common/Traits/World/ValidateOrder.cs index d6559d52d9..64a6d81488 100644 --- a/OpenRA.Mods.Common/Traits/World/ValidateOrder.cs +++ b/OpenRA.Mods.Common/Traits/World/ValidateOrder.cs @@ -29,18 +29,17 @@ namespace OpenRA.Mods.Common.Traits if (subjectClient == null) { - Game.Debug("Order sent to {0}: resolved ClientIndex `{1}` doesn't exist", order.Subject.Owner.PlayerName, subjectClientId); + Log.Write("debug", "Order sent to {0}: resolved ClientIndex `{1}` doesn't exist", order.Subject.Owner.PlayerName, subjectClientId); return false; } var isBotOrder = subjectClient.Bot != null && clientId == subjectClient.BotControllerClientIndex; - // Drop exploiting orders + // Drop orders from players who shouldn't be able to control this actor + // This may be because the owner changed within the last net tick, + // or, less likely, the client may be trying to do something malicious. if (subjectClientId != clientId && !isBotOrder) - { - Game.Debug("Detected exploit order from client {0}: {1}", clientId, order.OrderString); return false; - } return order.Subject.AcceptsOrder(order.OrderString); }