diff --git a/OpenRA.Mods.Common/Traits/Render/Hovers.cs b/OpenRA.Mods.Common/Traits/Render/Hovers.cs index 1b97a4509f..52c61219fe 100644 --- a/OpenRA.Mods.Common/Traits/Render/Hovers.cs +++ b/OpenRA.Mods.Common/Traits/Render/Hovers.cs @@ -18,20 +18,21 @@ using OpenRA.Traits; namespace OpenRA.Mods.Common.Traits { [Desc("Changes the visual Z position periodically.")] - public class HoversInfo : ITraitInfo, Requires + public class HoversInfo : UpgradableTraitInfo, Requires { [Desc("Amount of Z axis changes in world units.")] public readonly int OffsetModifier = -43; - public object Create(ActorInitializer init) { return new Hovers(this, init.Self); } + public override object Create(ActorInitializer init) { return new Hovers(this, init.Self); } } - public class Hovers : IRenderModifier + public class Hovers : UpgradableTrait, IRenderModifier { readonly HoversInfo info; readonly bool aircraft; public Hovers(HoversInfo info, Actor self) + : base(info) { this.info = info; aircraft = self.Info.HasTraitInfo(); @@ -39,7 +40,7 @@ namespace OpenRA.Mods.Common.Traits public IEnumerable ModifyRender(Actor self, WorldRenderer wr, IEnumerable r) { - if (self.World.Paused) + if (self.World.Paused || IsTraitDisabled) return r; var visualOffset = !aircraft || self.CenterPosition.Z > 0 ? (int)Math.Abs((self.ActorID + Game.LocalTick) / 5 % 4 - 1) - 1 : 0; diff --git a/mods/ts/rules/aircraft.yaml b/mods/ts/rules/aircraft.yaml index 713db341a0..1886a53be2 100644 --- a/mods/ts/rules/aircraft.yaml +++ b/mods/ts/rules/aircraft.yaml @@ -97,7 +97,9 @@ ORCA: PipTypeEmpty: AmmoEmpty AutoTarget: RenderSprites: - Hovers: + Hovers@AIRBORNE: + UpgradeTypes: airborne + UpgradeMinEnabledLevel: 1 ORCAB: Inherits: ^Plane @@ -139,7 +141,9 @@ ORCAB: PipTypeEmpty: AmmoEmpty AutoTarget: RenderSprites: - Hovers: + Hovers@AIRBORNE: + UpgradeTypes: airborne + UpgradeMinEnabledLevel: 1 ORCATRAN: Inherits: ^Helicopter @@ -172,7 +176,9 @@ ORCATRAN: MaxWeight: 5 PipCount: 5 UnloadVoice: Move - Hovers: + Hovers@AIRBORNE: + UpgradeTypes: airborne + UpgradeMinEnabledLevel: 1 TRNSPORT: Inherits: ^Helicopter @@ -202,7 +208,9 @@ TRNSPORT: Range: 2c0 Type: CenterPosition RenderSprites: - Hovers: + Hovers@AIRBORNE: + UpgradeTypes: airborne + UpgradeMinEnabledLevel: 1 Selectable: Bounds: 44,32,0,-8 @@ -285,7 +293,9 @@ APACHE: WithSpriteRotorOverlay: Offset: 85,0,384 RenderSprites: - Hovers: + Hovers@AIRBORNE: + UpgradeTypes: airborne + UpgradeMinEnabledLevel: 1 HUNTER: Inherits@1: ^GainsExperience