epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor occupied cells visibility checks.

Browse Source 
Provide some common extension methods to reduce code duplication, and also use loops instead of LINQ to reduce allocations and provide a minor speedup.
This commit is contained in:
RoosterDragon
2015-09-06 22:41:04 +01:00
parent 5e4e085a85
commit d70eea5adc
5 changed files with 43 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
OpenRA.Mods.Common/Traits/Modifiers/HiddenUnderFog.cs
View File

@@ -33,8 +33,7 @@ namespace OpenRA.Mods.Common.Traits
return base.IsVisibleInner(self, byPlayer);
if (Info.Type == VisibilityType.Footprint)
return self.OccupiesSpace.OccupiedCells()
.Any(o => byPlayer.Shroud.IsVisible(o.First));
return byPlayer.Shroud.AnyVisible(self.OccupiesSpace.OccupiedCells());
return byPlayer.Shroud.IsVisible(self.CenterPosition);
}