From df0021eeedc11944a19acc748cf9ee9e39140160 Mon Sep 17 00:00:00 2001 From: reaperrr Date: Thu, 20 Oct 2016 16:58:55 +0200 Subject: [PATCH] Move check for explicit interface violations to the top The interface violation check is fast, so it doesn't really delay the rest, while you don't have to wait for all other code checks to finish to check for violations. --- Makefile | 6 +++--- make.ps1 | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 3364a9d9a7..c404363cd4 100644 --- a/Makefile +++ b/Makefile @@ -189,6 +189,9 @@ check-scripts: @luac -p $(shell find lua/* -iname '*.lua') check: utility mods + @echo + @echo "Checking for explicit interface violations..." + @mono --debug OpenRA.Utility.exe all --check-explicit-interfaces @echo @echo "Checking for code style violations in OpenRA.Game..." @mono --debug OpenRA.Utility.exe ra --check-code-style OpenRA.Game @@ -220,9 +223,6 @@ check: utility mods @echo "Checking for code style violations in OpenRA.Test..." @mono --debug OpenRA.Utility.exe ra --check-code-style OpenRA.Test @echo - @echo "Checking for explicit interface violations..." - @mono --debug OpenRA.Utility.exe all --check-explicit-interfaces - @echo @echo "Checking for code style violations in OpenRA.Server..." @mono --debug OpenRA.Utility.exe ra --check-code-style OpenRA.Server diff --git a/make.ps1 b/make.ps1 index d857e9d0e2..77106319f3 100644 --- a/make.ps1 +++ b/make.ps1 @@ -164,6 +164,8 @@ elseif ($command -eq "check") { if (Test-Path OpenRA.Utility.exe) { + echo "Checking for explicit interface violations..." + ./OpenRA.Utility.exe all --check-explicit-interfaces echo "Checking for code style violations in OpenRA.Platforms.Default..." ./OpenRA.Utility.exe cnc --check-code-style OpenRA.Platforms.Default echo "Checking for code style violations in OpenRA.GameMonitor..." @@ -184,8 +186,6 @@ elseif ($command -eq "check") ./OpenRA.Utility.exe cnc --check-code-style OpenRA.Utility echo "Checking for code style violations in OpenRA.Test..." ./OpenRA.Utility.exe cnc --check-code-style OpenRA.Test - echo "Checking for explicit interface violations..." - ./OpenRA.Utility.exe all --check-explicit-interfaces } else {