epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #7488 from RoosterDragon/trait-remove-perf

Browse Source 
Speed up TraitContainer.RemoveActor.
This commit is contained in:
Paul Chote
2015-02-20 17:45:40 +00:00
parent 4ac8199e8e a3898db660
commit df7588f1bc
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
OpenRA.Game/TraitDictionary.cs
View File

@@ -231,14 +231,15 @@ namespace OpenRA
public void RemoveActor(uint actor)
{
for (var i = actors.Count - 1; i >= 0; i--)
{
if (actors[i].ActorID == actor)
{
actors.RemoveAt(i);
traits.RemoveAt(i);
}
}
var startIndex = actors.BinarySearchMany(actor);
if (startIndex >= actors.Count || actors[startIndex].ActorID != actor)
return;
var endIndex = startIndex + 1;
while (endIndex < actors.Count && actors[endIndex].ActorID == actor)
endIndex++;
var count = endIndex - startIndex;
actors.RemoveRange(startIndex, count);
traits.RemoveRange(startIndex, count);
}
}
}