epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix NullReferenceExceptions during client pings

Browse Source
This commit is contained in:
Matthias Mailänder
2015-06-06 13:13:01 +02:00
parent 1651bd817b
commit e228601a5c
2 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Game/Server/Server.cs
View File

@@ -489,7 +489,11 @@ namespace OpenRA.Server
break; break;
} }
var pingFromClient = LobbyInfo.PingFromClient(GetClient(conn)); var client = GetClient(conn);
if (client == null)
return;
var pingFromClient = LobbyInfo.PingFromClient(client);
if (pingFromClient == null) if (pingFromClient == null)
return; return;

7
OpenRA.Mods.Common/ServerTraits/LobbyCommands.cs
View File

@@ -186,9 +186,12 @@ namespace OpenRA.Mods.Common.Server
server.LobbyInfo.Clients.Remove(occupant); server.LobbyInfo.Clients.Remove(occupant);
server.SyncLobbyClients(); server.SyncLobbyClients();
var ping = server.LobbyInfo.PingFromClient(occupant); var ping = server.LobbyInfo.PingFromClient(occupant);
if (ping != null)
{
server.LobbyInfo.ClientPings.Remove(ping); server.LobbyInfo.ClientPings.Remove(ping);
server.SyncClientPing(); server.SyncClientPing();
} }
}
else else
{ {
var occupantConn = server.Conns.FirstOrDefault(c => c.PlayerIndex == occupant.Index); var occupantConn = server.Conns.FirstOrDefault(c => c.PlayerIndex == occupant.Index);
@@ -221,7 +224,11 @@ namespace OpenRA.Mods.Common.Server
{ {
server.LobbyInfo.Clients.Remove(occupant); server.LobbyInfo.Clients.Remove(occupant);
var ping = server.LobbyInfo.PingFromClient(occupant); var ping = server.LobbyInfo.PingFromClient(occupant);
if (ping != null)
{
server.LobbyInfo.ClientPings.Remove(ping); server.LobbyInfo.ClientPings.Remove(ping);
server.SyncClientPing();
}
} }
server.SyncLobbyClients(); server.SyncLobbyClients();