diff --git a/OpenRA.Mods.Common/Traits/Buildings/BaseProvider.cs b/OpenRA.Mods.Common/Traits/Buildings/BaseProvider.cs index 6a8760d765..599138d4e1 100644 --- a/OpenRA.Mods.Common/Traits/Buildings/BaseProvider.cs +++ b/OpenRA.Mods.Common/Traits/Buildings/BaseProvider.cs @@ -30,10 +30,12 @@ namespace OpenRA.Mods.Common.Traits public class BaseProvider : ITick, IPostRenderSelection, ISelectionBar { public readonly BaseProviderInfo Info; - DeveloperMode devMode; - Actor self; + readonly DeveloperMode devMode; + readonly Actor self; + int total; int progress; + bool allyBuildEnabled; public BaseProvider(Actor self, BaseProviderInfo info) { @@ -41,6 +43,7 @@ namespace OpenRA.Mods.Common.Traits this.self = self; devMode = self.Owner.PlayerActor.Trait(); progress = total = info.InitialDelay; + allyBuildEnabled = self.World.WorldActor.Trait().AllyBuildRadiusEnabled; } public void Tick(Actor self) @@ -61,8 +64,7 @@ namespace OpenRA.Mods.Common.Traits bool ValidRenderPlayer() { - var allyBuildRadius = self.World.LobbyInfo.GlobalSettings.AllyBuildRadius; - return self.Owner == self.World.RenderPlayer || (allyBuildRadius && self.Owner.IsAlliedWith(self.World.RenderPlayer)); + return self.Owner == self.World.RenderPlayer || (allyBuildEnabled && self.Owner.IsAlliedWith(self.World.RenderPlayer)); } public IEnumerable RenderAfterWorld(WorldRenderer wr) diff --git a/OpenRA.Mods.Common/Traits/Buildings/Building.cs b/OpenRA.Mods.Common/Traits/Buildings/Building.cs index 0e8a995917..16d4cd6299 100644 --- a/OpenRA.Mods.Common/Traits/Buildings/Building.cs +++ b/OpenRA.Mods.Common/Traits/Buildings/Building.cs @@ -43,9 +43,11 @@ namespace OpenRA.Mods.Common.Traits public Actor FindBaseProvider(World world, Player p, CPos topLeft) { var center = world.Map.CenterOfCell(topLeft) + FootprintUtils.CenterOffset(world, this); + var allyBuildEnabled = world.WorldActor.Trait().AllyBuildRadiusEnabled; + foreach (var bp in world.ActorsWithTrait()) { - var validOwner = bp.Actor.Owner == p || (world.LobbyInfo.GlobalSettings.AllyBuildRadius && bp.Actor.Owner.Stances[p] == Stance.Ally); + var validOwner = bp.Actor.Owner == p || (allyBuildEnabled && bp.Actor.Owner.Stances[p] == Stance.Ally); if (!validOwner || !bp.Trait.Ready()) continue; @@ -76,7 +78,7 @@ namespace OpenRA.Mods.Common.Traits var nearnessCandidates = new List(); var bi = world.WorldActor.Trait(); - var allyBuildRadius = world.LobbyInfo.GlobalSettings.AllyBuildRadius; + var allyBuildEnabled = world.WorldActor.Trait().AllyBuildRadiusEnabled; for (var y = scanStart.Y; y < scanEnd.Y; y++) { @@ -89,14 +91,14 @@ namespace OpenRA.Mods.Common.Traits if (buildingAtPos == null) { var unitsAtPos = world.ActorMap.GetActorsAt(pos).Where(a => a.IsInWorld - && (a.Owner == p || (allyBuildRadius && a.Owner.Stances[p] == Stance.Ally)) + && (a.Owner == p || (allyBuildEnabled && a.Owner.Stances[p] == Stance.Ally)) && a.Info.HasTraitInfo()); if (unitsAtPos.Any()) nearnessCandidates.Add(pos); } else if (buildingAtPos.IsInWorld && buildingAtPos.Info.HasTraitInfo() - && (buildingAtPos.Owner == p || (allyBuildRadius && buildingAtPos.Owner.Stances[p] == Stance.Ally))) + && (buildingAtPos.Owner == p || (allyBuildEnabled && buildingAtPos.Owner.Stances[p] == Stance.Ally))) nearnessCandidates.Add(pos); } } diff --git a/OpenRA.Mods.Common/Traits/World/MapBuildRadius.cs b/OpenRA.Mods.Common/Traits/World/MapBuildRadius.cs index d3becc3a00..1bad95edf3 100644 --- a/OpenRA.Mods.Common/Traits/World/MapBuildRadius.cs +++ b/OpenRA.Mods.Common/Traits/World/MapBuildRadius.cs @@ -24,5 +24,13 @@ namespace OpenRA.Mods.Common.Traits public readonly bool AllyBuildRadiusLocked = false; } - public class MapBuildRadius { } + public class MapBuildRadius : INotifyCreated + { + public bool AllyBuildRadiusEnabled { get; private set; } + + void INotifyCreated.Created(Actor self) + { + AllyBuildRadiusEnabled = self.World.LobbyInfo.GlobalSettings.AllyBuildRadius; + } + } }