From e5309ee586979ba74a87b3b8efa92dba27be2a1d Mon Sep 17 00:00:00 2001
From: Paul Chote <pchote@users.noreply.github.com>
Date: Sat, 15 Feb 2020 11:51:49 +0000
Subject: [PATCH] Remove unused InstalledMods.Icons cache.

---
 OpenRA.Game/InstalledMods.cs | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/OpenRA.Game/InstalledMods.cs b/OpenRA.Game/InstalledMods.cs
index c439be16a8..6d8e6e38b5 100644
--- a/OpenRA.Game/InstalledMods.cs
+++ b/OpenRA.Game/InstalledMods.cs
@@ -26,16 +26,12 @@ namespace OpenRA
 		readonly Dictionary<string, Manifest> mods;
 		readonly SheetBuilder sheetBuilder;
 
-		readonly Dictionary<string, Sprite> icons = new Dictionary<string, Sprite>();
-		public readonly IReadOnlyDictionary<string, Sprite> Icons;
-
 		/// <summary>Initializes the collection of locally installed mods.</summary>
 		/// <param name="searchPaths">Filesystem paths to search for mod packages.</param>
 		/// <param name="explicitPaths">Filesystem paths to additional mod packages.</param>
 		public InstalledMods(IEnumerable<string> searchPaths, IEnumerable<string> explicitPaths)
 		{
 			sheetBuilder = new SheetBuilder(SheetType.BGRA, 256);
-			Icons = new ReadOnlyDictionary<string, Sprite>(icons);
 			mods = GetInstalledMods(searchPaths, explicitPaths);
 		}
 
@@ -76,20 +72,7 @@ namespace OpenRA
 
 				package = new Folder(path);
 				if (package.Contains("mod.yaml"))
-				{
-					var manifest = new Manifest(id, package);
-
-					if (package.Contains("icon.png"))
-					{
-						using (var stream = package.GetStream("icon.png"))
-							if (stream != null)
-								icons[id] = sheetBuilder.Add(new Png(stream));
-					}
-					else if (!manifest.Metadata.Hidden)
-						Log.Write("debug", "Mod '{0}' is missing 'icon.png'.".F(path));
-
-					return manifest;
-				}
+					return new Manifest(id, package);
 			}
 			catch (Exception e)
 			{