From e685731b337d76ba4d03b7dc84105029870236d4 Mon Sep 17 00:00:00 2001 From: abcdefg30 Date: Fri, 7 Jan 2022 02:44:20 +0100 Subject: [PATCH] Add an update rule for the removal of AttackFrontal's FacingTolerance --- .../20201213/AttackFrontalFacingTolerance.cs | 37 +++++++++++++++++++ OpenRA.Mods.Common/UpdateRules/UpdatePath.cs | 1 + 2 files changed, 38 insertions(+) create mode 100644 OpenRA.Mods.Common/UpdateRules/Rules/20201213/AttackFrontalFacingTolerance.cs diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20201213/AttackFrontalFacingTolerance.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20201213/AttackFrontalFacingTolerance.cs new file mode 100644 index 0000000000..532e1652c1 --- /dev/null +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20201213/AttackFrontalFacingTolerance.cs @@ -0,0 +1,37 @@ +#region Copyright & License Information +/* + * Copyright 2007-2022 The OpenRA Developers (see AUTHORS) + * This file is part of OpenRA, which is free software. It is made + * available to you under the terms of the GNU General Public License + * as published by the Free Software Foundation, either version 3 of + * the License, or (at your option) any later version. For more + * information, see COPYING. + */ +#endregion + +using System.Collections.Generic; + +namespace OpenRA.Mods.Common.UpdateRules.Rules +{ + public class AttackFrontalFacingTolerance : UpdateRule + { + public override string Name => "Adds the old default value for AttackFrontal's FacingTolerance."; + + public override string Description => "The tolerance for the attack angle was defined twice on AttackFrontal. This override has to be defined in the rules now."; + + public override IEnumerable UpdateActorNode(ModData modData, MiniYamlNode actorNode) + { + foreach (var attackFrontal in actorNode.ChildrenMatching("AttackFrontal", includeRemovals: false)) + { + var facingTolerance = attackFrontal.LastChildMatching("FacingTolerance"); + if (facingTolerance != null) + continue; + + var facingToleranceNode = new MiniYamlNode("FacingTolerance", FieldSaver.FormatValue(WAngle.Zero)); + attackFrontal.AddNode(facingToleranceNode); + } + + yield break; + } + } +} diff --git a/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs b/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs index f0c014423a..323db26ba3 100644 --- a/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs +++ b/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs @@ -90,6 +90,7 @@ namespace OpenRA.Mods.Common.UpdateRules new UnhardcodeSquadManager(), new RenameSupportPowerDescription(), new AttackBomberFacingTolerance(), + new AttackFrontalFacingTolerance(), new RenameCloakTypes(), }) };