From e8027a6fdff0ca7f617887fccdca539c5518fa61 Mon Sep 17 00:00:00 2001 From: reaperrr Date: Tue, 25 Oct 2016 18:27:05 +0200 Subject: [PATCH] Remove hardcoded buildComplete delay in some overlays There certainly was and possibly still is some issue this was trying to work around, but unless it's a deal-breaker, we should rather try to fix that issue directly instead of keeping some uncommented magical work-around. --- OpenRA.Mods.Common/Traits/Render/WithDockedOverlay.cs | 3 +-- OpenRA.Mods.Common/Traits/Render/WithRepairOverlay.cs | 3 +-- OpenRA.Mods.D2k/Traits/Render/WithDeliveryOverlay.cs | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/OpenRA.Mods.Common/Traits/Render/WithDockedOverlay.cs b/OpenRA.Mods.Common/Traits/Render/WithDockedOverlay.cs index 96c2e865d3..27fae6bd63 100644 --- a/OpenRA.Mods.Common/Traits/Render/WithDockedOverlay.cs +++ b/OpenRA.Mods.Common/Traits/Render/WithDockedOverlay.cs @@ -67,8 +67,7 @@ namespace OpenRA.Mods.Common.Traits.Render void INotifyBuildComplete.BuildingComplete(Actor self) { - self.World.AddFrameEndTask(w => w.Add(new DelayedAction(120, () => - buildComplete = true))); + buildComplete = true; } void INotifySold.Sold(Actor self) { } diff --git a/OpenRA.Mods.Common/Traits/Render/WithRepairOverlay.cs b/OpenRA.Mods.Common/Traits/Render/WithRepairOverlay.cs index a330e4f29e..2727418f6a 100644 --- a/OpenRA.Mods.Common/Traits/Render/WithRepairOverlay.cs +++ b/OpenRA.Mods.Common/Traits/Render/WithRepairOverlay.cs @@ -61,8 +61,7 @@ namespace OpenRA.Mods.Common.Traits.Render void INotifyBuildComplete.BuildingComplete(Actor self) { - self.World.AddFrameEndTask(w => w.Add(new DelayedAction(120, () => - buildComplete = true))); + buildComplete = true; } void INotifySold.Sold(Actor self) { } diff --git a/OpenRA.Mods.D2k/Traits/Render/WithDeliveryOverlay.cs b/OpenRA.Mods.D2k/Traits/Render/WithDeliveryOverlay.cs index 5d8ca9bbdf..97d2d03f99 100644 --- a/OpenRA.Mods.D2k/Traits/Render/WithDeliveryOverlay.cs +++ b/OpenRA.Mods.D2k/Traits/Render/WithDeliveryOverlay.cs @@ -71,8 +71,7 @@ namespace OpenRA.Mods.D2k.Traits.Render void INotifyBuildComplete.BuildingComplete(Actor self) { - self.World.AddFrameEndTask(w => w.Add(new DelayedAction(120, () => - buildComplete = true))); + buildComplete = true; } void INotifySold.Sold(Actor self) { }