epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix invalid Transform location exploit.

Browse Source
This commit is contained in:
Paul Chote
2017-03-04 00:02:51 +00:00
parent 6fbd6bcb4c
commit e98c2eef68
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Mods.Common/Traits/Transforms.cs
View File

@@ -138,6 +138,12 @@ namespace OpenRA.Mods.Common.Traits
Faction = faction Faction = faction
}; };
// Try and stop the actor from doing anything between the sanity checks above
// and the actual transform, which we're about to queue.
// TODO: The proper way to do this is to write all the transform code as a nested activity.
if (self.CurrentActivity.NextInQueue != null)
self.CurrentActivity.NextInQueue.Cancel(self);
var makeAnimation = self.TraitOrDefault<WithMakeAnimation>(); var makeAnimation = self.TraitOrDefault<WithMakeAnimation>();
if (makeAnimation != null) if (makeAnimation != null)
makeAnimation.Reverse(self, transform); makeAnimation.Reverse(self, transform);