add new long WRange.RangeSquared to avoid integer overflows

2015-05-31 23:51:30 +02:00
parent 79edf648a7
commit ea5003cd2d
15 changed files with 18 additions and 22 deletions
--- a/OpenRA.Game/Traits/Target.cs
+++ b/OpenRA.Game/Traits/Target.cs
@@ -146,8 +146,7 @@ namespace OpenRA.Traits
 				return false;

 			// Target ranges are calculated in 2D, so ignore height differences
-			var rangeSquared = range.Range * range.Range;
-			return Positions.Any(t => (t - origin).HorizontalLengthSquared <= rangeSquared);
+			return Positions.Any(t => (t - origin).HorizontalLengthSquared <= range.RangeSquared);
 		}

 		public override string ToString()