Merge pull request #8662 from atlimit8/UpgradableTargetableUnit

Upgradable TargetableUnit & apply to Allies 03

OpenRA.Mods.Common/Traits/Air/TargetableAircraft.cs

@@ -35,8 +35,8 @@ namespace OpenRA.Mods.Common.Traits
 		{
 			get
 			{
-				return (self.CenterPosition.Z > 0) ? info.TargetTypes
+				return IsTraitDisabled ? None
-					: info.GroundedTargetTypes;
+					: (self.CenterPosition.Z > 0 ? info.TargetTypes : info.GroundedTargetTypes);
 			}
 		}
 	}

OpenRA.Mods.Common/Traits/TargetableUnit.cs

@@ -14,7 +14,7 @@ using OpenRA.Traits;
 namespace OpenRA.Mods.Common.Traits
 {
 	[Desc("Actor can be targeted.")]
-	public class TargetableUnitInfo : ITraitInfo, ITargetableInfo
+	public class TargetableUnitInfo : UpgradableTraitInfo, ITargetableInfo
 	{
 		[Desc("Target type. Used for filtering (in)valid targets.")]
 		public readonly string[] TargetTypes = { };
@@ -22,35 +22,37 @@ namespace OpenRA.Mods.Common.Traits
 
 		public bool RequiresForceFire = false;
 
-		public virtual object Create(ActorInitializer init) { return new TargetableUnit(init.Self, this); }
+		public override object Create(ActorInitializer init) { return new TargetableUnit(init.Self, this); }
 	}
 
-	public class TargetableUnit : ITargetable
+	public class TargetableUnit : UpgradableTrait<TargetableUnitInfo>, ITargetable
 	{
-		readonly TargetableUnitInfo info;
+		protected static readonly string[] None = new string[] { };
 		protected Cloak cloak;
 
 		public TargetableUnit(Actor self, TargetableUnitInfo info)
+			: base(info)
 		{
-			this.info = info;
 			cloak = self.TraitOrDefault<Cloak>();
 		}
 
 		public virtual bool TargetableBy(Actor self, Actor viewer)
 		{
+			if (IsTraitDisabled)
+				return false;
 			if (cloak == null || (!viewer.IsDead && viewer.HasTrait<IgnoresCloak>()))
 				return true;
 
 			return cloak.IsVisible(self, viewer.Owner);
 		}
 
-		public virtual string[] TargetTypes { get { return info.TargetTypes; } }
+		public virtual string[] TargetTypes { get { return IsTraitDisabled ? None : Info.TargetTypes; } }
 
 		public virtual IEnumerable<WPos> TargetablePositions(Actor self)
 		{
 			yield return self.CenterPosition;
 		}
 
-		public bool RequiresForceFire { get { return info.RequiresForceFire; } }
+		public bool RequiresForceFire { get { return Info.RequiresForceFire; } }
 	}
 }

OpenRA.Mods.RA/Traits/TargetableSubmarine.cs

@@ -34,7 +34,8 @@ namespace OpenRA.Mods.RA.Traits
 		{
 			get
 			{
-				return cloak.Cloaked ? info.CloakedTargetTypes : info.TargetTypes;
+				return IsTraitDisabled ? None
+					: (cloak.Cloaked ? info.CloakedTargetTypes : info.TargetTypes);
 			}
 		}
 	}

mods/ra/maps/allies-03a/map.yaml

@@ -1382,21 +1382,15 @@ Rules:
 		-ExternalCaptures:
 		Captures:
 			CaptureTypes: building
-		Cloak@JAIL:
+		TargetableUnit:
 			UpgradeTypes: jail
-			UpgradeMinEnabledLevel: 1
+			UpgradeMaxEnabledLevel: 0
-			InitialDelay: 0
-			CloakDelay: 0
-			Palette:
 		RenderSprites:
 			Image: E6
 	MEDI:
-		Cloak@JAIL:
+		TargetableUnit:
 			UpgradeTypes: jail
-			UpgradeMinEnabledLevel: 1
+			UpgradeMaxEnabledLevel: 0
-			InitialDelay: 0
-			CloakDelay: 0
-			Palette:
 	E7.noautotarget:
 		Inherits: E7
 		AutoTarget:

mods/ra/maps/allies-03b/map.yaml

@@ -1278,21 +1278,15 @@ Rules:
 		Captures:
 			CaptureTypes: building
 		WithInfantryBody:
-		Cloak@JAIL:
+		TargetableUnit:
 			UpgradeTypes: jail
-			UpgradeMinEnabledLevel: 1
+			UpgradeMaxEnabledLevel: 0
-			InitialDelay: 0
-			CloakDelay: 0
-			Palette:
 		RenderSprites:
 			Image: E6
 	MEDI:
-		Cloak@JAIL:
+		TargetableUnit:
 			UpgradeTypes: jail
-			UpgradeMinEnabledLevel: 1
+			UpgradeMaxEnabledLevel: 0
-			InitialDelay: 0
-			CloakDelay: 0
-			Palette:
 	E7.noautotarget:
 		Inherits: E7
 		AutoTarget:
@@ -1312,12 +1306,6 @@ Rules:
 	CAMERA:
 		RevealsShroud:
 			Range: 8c5
-	FTUR:
-		DetectCloaked:
-			Range: 0
-	DOME:
-		DetectCloaked:
-			Range: 0
 	CAMERA.VeryLarge:
 		Inherits: CAMERA
 		RevealsShroud: