From ed2e4eef174886b0a23c2b3cdead1b04aeb46eaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sun, 3 Aug 2014 09:56:45 +0200
Subject: [PATCH] make the change notifications more natural

---
 OpenRA.Mods.RA/ServerTraits/LobbyCommands.cs | 24 ++++++++++++--------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/OpenRA.Mods.RA/ServerTraits/LobbyCommands.cs b/OpenRA.Mods.RA/ServerTraits/LobbyCommands.cs
index 2db7e1751f..ad4cf05546 100644
--- a/OpenRA.Mods.RA/ServerTraits/LobbyCommands.cs
+++ b/OpenRA.Mods.RA/ServerTraits/LobbyCommands.cs
@@ -358,7 +358,8 @@ namespace OpenRA.Mods.RA.Server
 
 						bool.TryParse(s, out server.LobbyInfo.GlobalSettings.FragileAlliances);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Diplomacy Changes> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} {1} Diplomacy Changes."
+							.F(client.Name, server.LobbyInfo.GlobalSettings.FragileAlliances ? "enabled" : "disabled"));
 
 						return true;
 					}},
@@ -379,7 +380,8 @@ namespace OpenRA.Mods.RA.Server
 
 						bool.TryParse(s, out server.LobbyInfo.GlobalSettings.AllowCheats);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Allow Cheats> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} {1} Developer Cheats."
+							.F(client.Name, server.LobbyInfo.GlobalSettings.AllowCheats ? "allowed" : "disallowed"));
 
 						return true;
 					}},
@@ -400,7 +402,8 @@ namespace OpenRA.Mods.RA.Server
 
 						bool.TryParse(s, out server.LobbyInfo.GlobalSettings.Shroud);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Shroud> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} {1} Shroud."
+							.F(client.Name, server.LobbyInfo.GlobalSettings.Shroud ? "enabled" : "disabled"));
 
 						return true;
 					}},
@@ -422,7 +425,8 @@ namespace OpenRA.Mods.RA.Server
 
 						bool.TryParse(s, out server.LobbyInfo.GlobalSettings.Fog);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Fog of War> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} {1} Fog of War."
+							.F(client.Name, server.LobbyInfo.GlobalSettings.Fog ? "enabled" : "disabled"));
 
 						return true;
 					}},
@@ -484,7 +488,8 @@ namespace OpenRA.Mods.RA.Server
 
 						bool.TryParse(s, out server.LobbyInfo.GlobalSettings.Crates);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Crates Appear> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} {1} Crates Appear."
+							.F(client.Name, server.LobbyInfo.GlobalSettings.Crates ? "enabled" : "disabled"));
 
 						return true;
 					}},
@@ -505,7 +510,8 @@ namespace OpenRA.Mods.RA.Server
 
 						bool.TryParse(s, out server.LobbyInfo.GlobalSettings.AllyBuildRadius);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Build off Ally ConYards> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} {1} Build off Ally ConYards."
+							.F(client.Name, server.LobbyInfo.GlobalSettings.AllyBuildRadius ? "enabled" : "disabled"));
 
 						return true;
 					}},
@@ -546,7 +552,7 @@ namespace OpenRA.Mods.RA.Server
 
 						server.LobbyInfo.GlobalSettings.StartingUnitsClass = s;
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Starting Units> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} changed Starting Units to {1}.".F(client.Name, s));
 
 						return true;
 					}},
@@ -567,7 +573,7 @@ namespace OpenRA.Mods.RA.Server
 
 						server.LobbyInfo.GlobalSettings.StartingCash = Exts.ParseIntegerInvariant(s);
 						server.SyncLobbyGlobalSettings();
-						server.SendMessage("{0} modified <Starting Cash> to ${1}.".F(client.Name, s));
+						server.SendMessage("{0} changed Starting Cash to ${1}.".F(client.Name, s));
 
 						return true;
 					}},
@@ -588,7 +594,7 @@ namespace OpenRA.Mods.RA.Server
 
 						server.LobbyInfo.GlobalSettings.TechLevel = s;
 						server.SyncLobbyInfo();
-						server.SendMessage("{0} modified <Tech Level> to {1}.".F(client.Name, s));
+						server.SendMessage("{0} changed Tech Level to {1}.".F(client.Name, s));
 
 						return true;
 					}},