epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use TryGetValue instead of ContainsKey followed by indexing

Browse Source
This commit is contained in:
abcdefg30
2023-10-30 16:18:16 +01:00
committed by Gustas
parent 6fb7bb1c08
commit ed3ca78667
1 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
OpenRA.Mods.Common/Lint/CheckTranslationReference.cs
View File

@@ -203,33 +203,33 @@ namespace OpenRA.Mods.Common.Lint
var nodeType = node.Key.Split('@')[0];
foreach (var childNode in node.Value.Nodes)
{
if (translatables.ContainsKey(nodeType))
if (!translatables.TryGetValue(nodeType, out var translationNodes))
continue;
var childType = childNode.Key.Split('@')[0];
var field = Array.Find(translationNodes, t => t.Name == childType);
if (field.Name == null)
continue;
var key = childNode.Value.Value;
if (key == null)
{
var childType = childNode.Key.Split('@')[0];
var field = Array.Find(translatables[nodeType], t => t.Name == childType);
if (field.Name == null)
continue;
if (!field.Attribute.Optional)
emitError($"Widget `{node.Key}` in field `{childType}` has an empty translation reference.");
var key = childNode.Value.Value;
if (key == null)
{
if (!field.Attribute.Optional)
emitError($"Widget `{node.Key}` in field `{childType}` has an empty translation reference.");
continue;
}
if (referencedKeys.Contains(key))
continue;
if (!key.Any(char.IsLetter))
continue;
if (!translation.HasMessage(key))
emitWarning($"`{key}` defined by `{node.Key}` is not present in `{language}` translation.");
referencedKeys.Add(key);
continue;
}
if (referencedKeys.Contains(key))
continue;
if (!key.Any(char.IsLetter))
continue;
if (!translation.HasMessage(key))
emitWarning($"`{key}` defined by `{node.Key}` is not present in `{language}` translation.");
referencedKeys.Add(key);
}
foreach (var childNode in node.Value.Nodes)