epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use TryGetValue instead of ContainsKey followed by indexing

Browse Source
This commit is contained in:
abcdefg30
2023-10-30 16:18:16 +01:00
committed by Gustas
parent 6fb7bb1c08
commit ed3ca78667
1 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
OpenRA.Mods.Common/Lint/CheckTranslationReference.cs
View File

@@ -203,10 +203,11 @@ namespace OpenRA.Mods.Common.Lint
var nodeType = node.Key.Split('@')[0]; var nodeType = node.Key.Split('@')[0];
foreach (var childNode in node.Value.Nodes) foreach (var childNode in node.Value.Nodes)
{ {
if (translatables.ContainsKey(nodeType)) if (!translatables.TryGetValue(nodeType, out var translationNodes))
{ continue;
var childType = childNode.Key.Split('@')[0]; var childType = childNode.Key.Split('@')[0];
var field = Array.Find(translatables[nodeType], t => t.Name == childType); var field = Array.Find(translationNodes, t => t.Name == childType);
if (field.Name == null) if (field.Name == null)
continue; continue;
@@ -230,7 +231,6 @@ namespace OpenRA.Mods.Common.Lint
referencedKeys.Add(key); referencedKeys.Add(key);
} }
}
foreach (var childNode in node.Value.Nodes) foreach (var childNode in node.Value.Nodes)
if (childNode.Key == "Children") if (childNode.Key == "Children")