From edbd65bdf368b288c27e1a4be3effe5c11980ccd Mon Sep 17 00:00:00 2001 From: Chris Forbes Date: Tue, 7 Oct 2014 18:17:09 +1300 Subject: [PATCH] filesystem: Fix benign use of loop variable in closure This closure never outlives a single loop iteration. --- OpenRA.Game/FileSystem/GlobalFileSystem.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/OpenRA.Game/FileSystem/GlobalFileSystem.cs b/OpenRA.Game/FileSystem/GlobalFileSystem.cs index 8e45075217..ec7ced255a 100644 --- a/OpenRA.Game/FileSystem/GlobalFileSystem.cs +++ b/OpenRA.Game/FileSystem/GlobalFileSystem.cs @@ -199,13 +199,14 @@ namespace OpenRA.FileSystem foreach (var ext in exts) { + var possibleName = filename + ext; var folder = MountedFolders - .Where(x => x.Exists(filename + ext)) + .Where(x => x.Exists(possibleName)) .MaxByOrDefault(x => x.Priority); if (folder != null) { - s = folder.GetContent(filename + ext); + s = folder.GetContent(possibleName); return true; } }