Fix crash when Inherits has child nodes.

2018-10-31 17:32:23 +00:00
parent f968b169ad
commit f05e3e871f
1 changed files with 7 additions and 0 deletions
--- a/OpenRA.Mods.Common/Lint/CheckUnknownTraitFields.cs
+++ b/OpenRA.Mods.Common/Lint/CheckUnknownTraitFields.cs
@@ -41,6 +41,13 @@ namespace OpenRA.Mods.Common.Lint
 						continue;
 					}

+					// Inherits can never define children
+					if (NormalizeName(t.Key) == "Inherits" && t.Value.Nodes.Any())
+					{
+						emitError("{0} defines child nodes, which are not valid for Inherits.".F(t.Location));
+						continue;
+					}
+
 					var traitName = NormalizeName(t.Key);
 					var traitInfo = modData.ObjectCreator.FindType(traitName + "Info");
 					foreach (var field in t.Value.Nodes)