From f0ec8105b3ec9a74de787e278a137596c1f60144 Mon Sep 17 00:00:00 2001 From: Gustas <37534529+PunkPun@users.noreply.github.com> Date: Fri, 9 May 2025 16:49:53 +0300 Subject: [PATCH] Players and world don't need to be visible --- OpenRA.Mods.Common/Lint/CheckDefaultVisibility.cs | 3 +++ mods/cnc/rules/player.yaml | 1 - mods/cnc/rules/world.yaml | 1 - mods/d2k/rules/player.yaml | 1 - mods/d2k/rules/world.yaml | 1 - mods/ra/rules/player.yaml | 1 - mods/ra/rules/world.yaml | 1 - mods/ts/rules/player.yaml | 1 - mods/ts/rules/world.yaml | 1 - 9 files changed, 3 insertions(+), 8 deletions(-) diff --git a/OpenRA.Mods.Common/Lint/CheckDefaultVisibility.cs b/OpenRA.Mods.Common/Lint/CheckDefaultVisibility.cs index 07daf7548c..bb01118cc6 100644 --- a/OpenRA.Mods.Common/Lint/CheckDefaultVisibility.cs +++ b/OpenRA.Mods.Common/Lint/CheckDefaultVisibility.cs @@ -36,6 +36,9 @@ namespace OpenRA.Mods.Common.Lint // Catch TypeDictionary errors. try { + if (Enum.TryParse(actorInfo.Key, true, out _)) + continue; + var visibilityTypes = actorInfo.Value.TraitInfos(); var count = visibilityTypes.Count; diff --git a/mods/cnc/rules/player.yaml b/mods/cnc/rules/player.yaml index b39e206db6..38ca0aff22 100644 --- a/mods/cnc/rules/player.yaml +++ b/mods/cnc/rules/player.yaml @@ -1,5 +1,4 @@ ^BasePlayer: - AlwaysVisible: Shroud: PlayerResources: ResourceValues: diff --git a/mods/cnc/rules/world.yaml b/mods/cnc/rules/world.yaml index c94b24ec93..b112a34d25 100644 --- a/mods/cnc/rules/world.yaml +++ b/mods/cnc/rules/world.yaml @@ -1,5 +1,4 @@ ^BaseWorld: - AlwaysVisible: Inherits: ^Palettes ScreenMap: ActorMap: diff --git a/mods/d2k/rules/player.yaml b/mods/d2k/rules/player.yaml index 71c6cbd781..b3cb7b8450 100644 --- a/mods/d2k/rules/player.yaml +++ b/mods/d2k/rules/player.yaml @@ -1,5 +1,4 @@ ^BasePlayer: - AlwaysVisible: Shroud: PlayerResources: ResourceValues: diff --git a/mods/d2k/rules/world.yaml b/mods/d2k/rules/world.yaml index fca6ebb002..c9651e50aa 100644 --- a/mods/d2k/rules/world.yaml +++ b/mods/d2k/rules/world.yaml @@ -1,6 +1,5 @@ ^BaseWorld: Inherits: ^Palettes - AlwaysVisible: ScreenMap: ActorMap: Selection: diff --git a/mods/ra/rules/player.yaml b/mods/ra/rules/player.yaml index 1325ca3b41..451762b3a3 100644 --- a/mods/ra/rules/player.yaml +++ b/mods/ra/rules/player.yaml @@ -1,5 +1,4 @@ ^BasePlayer: - AlwaysVisible: Shroud: PlayerResources: ResourceValues: diff --git a/mods/ra/rules/world.yaml b/mods/ra/rules/world.yaml index 7b8dc6eedd..1a2deaf017 100644 --- a/mods/ra/rules/world.yaml +++ b/mods/ra/rules/world.yaml @@ -1,6 +1,5 @@ ^BaseWorld: Inherits: ^Palettes - AlwaysVisible: ActorMap: ScreenMap: Selection: diff --git a/mods/ts/rules/player.yaml b/mods/ts/rules/player.yaml index 33225902e6..a049e0eec6 100644 --- a/mods/ts/rules/player.yaml +++ b/mods/ts/rules/player.yaml @@ -1,5 +1,4 @@ ^BasePlayer: - AlwaysVisible: Shroud: PlayerResources: ResourceValues: diff --git a/mods/ts/rules/world.yaml b/mods/ts/rules/world.yaml index bb1579eb13..07a439ae78 100644 --- a/mods/ts/rules/world.yaml +++ b/mods/ts/rules/world.yaml @@ -1,6 +1,5 @@ ^BaseWorld: Inherits: ^Palettes - AlwaysVisible: ScreenMap: ActorMap: Selection: