epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lazily bind 'delegate' objects once, rather than creating them every click

Browse Source
This commit is contained in:
Chris Forbes
2010-03-16 19:12:42 +13:00
parent 03cf04c42e
commit f13ebcc0d2
1 changed files with 23 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
OpenRA.Game/Chrome/Widget.cs
View File

@@ -14,7 +14,9 @@ namespace OpenRA.Widgets
public readonly string Y = "0"; public readonly string Y = "0";
public readonly string Width = "0"; public readonly string Width = "0";
public readonly string Height = "0"; public readonly string Height = "0";
public readonly string Delegate = null; public readonly string Delegate = null;
public Lazy<IWidgetDelegate> InputHandler;
public bool Visible = true; public bool Visible = true;
public readonly List<Widget> Children = new List<Widget>(); public readonly List<Widget> Children = new List<Widget>();
@@ -51,8 +53,23 @@ namespace OpenRA.Widgets
{ {
child.Initialize(); child.Initialize();
EventBounds = Rectangle.Union(EventBounds, child.EventBounds); EventBounds = Rectangle.Union(EventBounds, child.EventBounds);
} }
}
InputHandler = Lazy.New(() => BindHandler(Delegate));
}
static IWidgetDelegate BindHandler(string name)
{
if (name == null) return null;
foreach (var mod in Game.ModAssemblies)
{
var act = (IWidgetDelegate)mod.First.CreateInstance(mod.Second + "." + name);
if (act != null) return act;
}
throw new InvalidOperationException("Cannot locate widget delegate: {0}".F(name));
}
public virtual void UpdateEventBounds() public virtual void UpdateEventBounds()
{ {
@@ -75,17 +92,9 @@ namespace OpenRA.Widgets
return true; return true;
// Mousedown // Mousedown
if (Delegate != null && mi.Event == MouseInputEvent.Down) // todo: route the other events too!
{ if (InputHandler.Value != null && mi.Event == MouseInputEvent.Down)
foreach (var mod in Game.ModAssemblies) return InputHandler.Value.OnClick(this, mi);
{
var act = (IWidgetDelegate)mod.First.CreateInstance(mod.Second + "."+Delegate);
if (act == null) continue;
return act.OnClick(this, mi);
}
throw new InvalidOperationException("Cannot locate widget delegate: {0}".F(Delegate));
}
return false; return false;
} }