epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LevelUpCrateAction: fix loop variable in closure bug

Browse Source 
This was a real bug -- if there were multiple recipients, we'd apply the
levels N times to the last recipient rather than once to each.
This commit is contained in:
Chris Forbes
2014-10-07 18:19:55 +13:00
parent edbd65bdf3
commit f2492f4155
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
OpenRA.Mods.RA/Crates/LevelUpCrateAction.cs
View File

@@ -68,9 +68,10 @@ namespace OpenRA.Mods.RA
foreach (var actor in inRange.Append(collector)) foreach (var actor in inRange.Append(collector))
{ {
actor.World.AddFrameEndTask(w => var recipient = actor; // loop variable in closure hazard
recipient.World.AddFrameEndTask(w =>
{ {
var gainsExperience = actor.TraitOrDefault<GainsExperience>(); var gainsExperience = recipient.TraitOrDefault<GainsExperience>();
if (gainsExperience != null) if (gainsExperience != null)
gainsExperience.GiveLevels(((LevelUpCrateActionInfo)info).Levels); gainsExperience.GiveLevels(((LevelUpCrateActionInfo)info).Levels);
}); });