From f4965915eeea41084392cb2ed7b2f809a97f7346 Mon Sep 17 00:00:00 2001
From: RoosterDragon <RoosterDragon@outlook.com>
Date: Sat, 3 Dec 2022 13:06:10 +0000
Subject: [PATCH] Fix PathFinderOverlay crash when deselecting actor moving
 along waypoints.

Set an actor moving along several waypoints whilst the /path-debug command is active, then deselect the actor. Each waypoint will add more information to the debugging overlay until it crashes with "Maximum two records permitted." This resolves the crash by no longer adding new debugging information once the actor is deselected.
---
 OpenRA.Mods.Common/Traits/World/PathFinderOverlay.cs | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/OpenRA.Mods.Common/Traits/World/PathFinderOverlay.cs b/OpenRA.Mods.Common/Traits/World/PathFinderOverlay.cs
index a31e5b0154..eb5f78c3e9 100644
--- a/OpenRA.Mods.Common/Traits/World/PathFinderOverlay.cs
+++ b/OpenRA.Mods.Common/Traits/World/PathFinderOverlay.cs
@@ -69,6 +69,7 @@ namespace OpenRA.Mods.Common.Traits
 		public bool Enabled { get; private set; }
 
 		Actor forActor;
+		bool record;
 		CPos[] sourceCells;
 		CPos? targetCell;
 
@@ -106,11 +107,15 @@ namespace OpenRA.Mods.Common.Traits
 			if (!Enabled)
 			{
 				forActor = null;
+				record = false;
 				return;
 			}
 
 			if (!actor.World.Selection.Contains(actor))
+			{
+				record = false;
 				return;
+			}
 
 			abstractEdges1 = null;
 			abstractEdges2 = null;
@@ -119,11 +124,12 @@ namespace OpenRA.Mods.Common.Traits
 			sourceCells = sources.ToArray();
 			targetCell = target;
 			forActor = actor;
+			record = true;
 		}
 
 		public PathSearch.IRecorder RecordAbstractEdges(Actor actor)
 		{
-			if (forActor != actor)
+			if (!record || forActor != actor)
 				return null;
 			if (abstractEdges1 == null)
 				return abstractEdges1 = new Record();
@@ -134,7 +140,7 @@ namespace OpenRA.Mods.Common.Traits
 
 		public PathSearch.IRecorder RecordLocalEdges(Actor actor)
 		{
-			if (forActor != actor)
+			if (!record || forActor != actor)
 				return null;
 			if (localEdges1 == null)
 				return localEdges1 = new Record();