From f5d1fe4bc47524093d2aa82325a2f6f9a8dcefbc Mon Sep 17 00:00:00 2001 From: RoosterDragon Date: Sat, 29 Jan 2022 20:21:56 +0000 Subject: [PATCH] Use more efficient search in MergeIntoResolved Switch Enumerable.FirstOrDefault to List.Find. The latter can avoid some allocations because the concrete collection type is known. --- OpenRA.Game/MiniYaml.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OpenRA.Game/MiniYaml.cs b/OpenRA.Game/MiniYaml.cs index 0c31373c4d..4d9169b72b 100644 --- a/OpenRA.Game/MiniYaml.cs +++ b/OpenRA.Game/MiniYaml.cs @@ -338,7 +338,7 @@ namespace OpenRA static void MergeIntoResolved(MiniYamlNode overrideNode, List existingNodes, Dictionary tree, Dictionary inherited) { - var existingNode = existingNodes.FirstOrDefault(n => n.Key == overrideNode.Key); + var existingNode = existingNodes.Find(n => n.Key == overrideNode.Key); if (existingNode != null) { existingNode.Value = MergePartial(existingNode.Value, overrideNode.Value);