editor: Fix a benign loop-variable-inside-closure issue

The getter is accessed exactly once, at call time.
The setter is stored, and invoked later on losing focus, but we pass a
bogus one anyway, so there is no issue.
This commit is contained in:
Chris Forbes
2014-10-07 18:12:41 +13:00
parent 802eaac87b
commit f61b52ccae

View File

@@ -86,14 +86,17 @@ namespace OpenRA.Editor
// TODO: make this work properly // TODO: make this work properly
foreach (var init in Program.Rules.Actors[kv.Value.Type].GetInitKeys()) foreach (var init in Program.Rules.Actors[kv.Value.Type].GetInitKeys())
apd.AddRow(init.First, {
var initName = init.First;
apd.AddRow(initName,
apd.MakeEditorControl(init.Second, apd.MakeEditorControl(init.Second,
() => () =>
{ {
var nodesDict = objSaved.ToDictionary(); var nodesDict = objSaved.ToDictionary();
return nodesDict.ContainsKey(init.First) ? nodesDict[init.First].Value : null; return nodesDict.ContainsKey(initName) ? nodesDict[initName].Value : null;
}, },
_ => { })); _ => { }));
}
apd.ShowDialog(); apd.ShowDialog();