From f6ac32412d0f50435c2482b1bf300b74ad960e72 Mon Sep 17 00:00:00 2001 From: Paul Chote Date: Wed, 20 Feb 2019 17:14:04 +0000 Subject: [PATCH] Avoid resetting FrozenActor.Hidden when refreshing GPS. --- OpenRA.Mods.Cnc/Traits/FrozenUnderFogUpdatedByGps.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/OpenRA.Mods.Cnc/Traits/FrozenUnderFogUpdatedByGps.cs b/OpenRA.Mods.Cnc/Traits/FrozenUnderFogUpdatedByGps.cs index 34b265ed5f..70448adafc 100644 --- a/OpenRA.Mods.Cnc/Traits/FrozenUnderFogUpdatedByGps.cs +++ b/OpenRA.Mods.Cnc/Traits/FrozenUnderFogUpdatedByGps.cs @@ -32,7 +32,11 @@ namespace OpenRA.Mods.Cnc.Traits // This only makes sense if the frozen actor has already been revealed (i.e. has renderables) if (fa.HasRenderables) { + // HACK: RefreshState updated *all* actor state, not just the owner + // This is generally bogus, and specifically breaks cursors and tooltips by setting Hidden to false + var hidden = fa.Hidden; fa.RefreshState(); + fa.Hidden = hidden; fa.NeedRenderables = true; } };