Fix RCS1134

OpenRA.Mods.Common/Activities/DeployForGrantedCondition.cs

@@ -50,8 +50,6 @@ namespace OpenRA.Mods.Common.Activities
 			if (NextActivity != null)
 				foreach (var n in NextActivity.TargetLineNodes(self))
 					yield return n;
-
-			yield break;
 		}
 	}
 

OpenRA.Mods.Common/Activities/Move/AttackMoveActivity.cs

@@ -103,8 +103,6 @@ namespace OpenRA.Mods.Common.Activities
 		{
 			foreach (var n in getMove().TargetLineNodes(self))
 				yield return n;
-
-			yield break;
 		}
 	}
 }

OpenRA.Mods.Common/Activities/Move/Nudge.cs

@@ -59,8 +59,6 @@ namespace OpenRA.Mods.Common.Traits
 			if (ChildActivity != null)
 				foreach (var n in ChildActivity.TargetLineNodes(self))
 					yield return n;
-
-			yield break;
 		}
 	}
 }

OpenRA.Mods.Common/Scripting/CallLuaFunc.cs

@@ -46,7 +46,6 @@ namespace OpenRA.Mods.Common.Activities
 		{
 			base.Cancel(self, keepQueue);
 			Dispose();
-			return;
 		}
 
 		public void Dispose()

OpenRA.Mods.Common/Traits/Cloak.cs

@@ -313,7 +313,7 @@ namespace OpenRA.Mods.Common.Traits
 				Uncloak();
 		}
 
-		void INotifySupportPower.Charged(Actor self) { return; }
+		void INotifySupportPower.Charged(Actor self) { }
 
 		void INotifySupportPower.Activated(Actor self)
 		{

OpenRA.Mods.Common/Traits/Conditions/GrantConditionOnDeployWithCharge.cs

@@ -256,8 +256,6 @@ namespace OpenRA.Mods.Common.Traits
 			if (NextActivity != null)
 				foreach (var n in NextActivity.TargetLineNodes(self))
 					yield return n;
-
-			yield break;
 		}
 	}
 }

OpenRA.Mods.Common/Traits/Player/ClassicParallelProductionQueue.cs

@@ -181,10 +181,7 @@ namespace OpenRA.Mods.Common.Traits
 			}
 
 			if (!anyProducers)
-			{
 				CancelProduction(unit.Name, 1);
-				return false;
-			}
 
 			return false;
 		}

OpenRA.Mods.Common/Traits/Player/ClassicProductionQueue.cs

@@ -131,10 +131,7 @@ namespace OpenRA.Mods.Common.Traits
 			}
 
 			if (!anyProducers)
-			{
 				CancelProduction(unit.Name, 1);
-				return false;
-			}
 
 			return false;
 		}

OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveLaysTerrain.cs

@@ -23,8 +23,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
 		{
 			if (actorNode.RemoveNodes("LaysTerrain") > 0)
 				yield return $"'LaysTerrain' was removed from {actorNode.Key} ({actorNode.Location.Filename}) without replacement.\n";
-
-			yield break;
 		}
 	}
 }

OpenRA.Mods.Common/UpdateRules/Rules/20230801/ExtractResourceStorageFromHarvester.cs

@@ -42,8 +42,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
 				storesResources.AddNode(resources);
 
 			actorNode.AddNode(storesResources);
-
-			yield break;
 		}
 	}
 }

OpenRA.Mods.Common/Widgets/Logic/Editor/ActorSelectorLogic.cs

@@ -225,7 +225,6 @@ namespace OpenRA.Mods.Common.Widgets.Logic
 				{
 					Log.Write("debug", $"Map editor ignoring actor {actor.Name}, "
 						+ $"because of missing sprites for tileset {World.Map.Rules.TerrainInfo.Id}.");
-					continue;
 				}
 			}
 		}

OpenRA.Mods.Common/Widgets/Logic/ReplayBrowserLogic.cs

@@ -570,7 +570,6 @@ namespace OpenRA.Mods.Common.Widgets.Logic
 			catch (Exception ex)
 			{
 				Log.Write("debug", ex.ToString());
-				return;
 			}
 		}