#region Copyright & License Information /* * Copyright (c) The OpenRA Developers and Contributors * This file is part of OpenRA, which is free software. It is made * available to you under the terms of the GNU General Public License * as published by the Free Software Foundation, either version 3 of * the License, or (at your option) any later version. For more * information, see COPYING. */ #endregion using System; using System.Collections.Generic; using System.IO; using System.Linq; using System.Reflection; using System.Text.RegularExpressions; using Linguini.Syntax.Ast; using Linguini.Syntax.Parser; using OpenRA.Mods.Common.Scripting; using OpenRA.Mods.Common.Scripting.Global; using OpenRA.Mods.Common.Traits; using OpenRA.Scripting; using OpenRA.Traits; using OpenRA.Widgets; namespace OpenRA.Mods.Common.Lint { sealed class CheckTranslationReference : ILintPass, ILintMapPass { static readonly Regex TranslationFilenameRegex = new(@"(?[^\/\\]+)\.ftl$"); void ILintMapPass.Run(Action emitError, Action emitWarning, ModData modData, Map map) { if (map.TranslationDefinitions == null) return; var usedKeys = GetUsedTranslationKeysInMap(map, emitWarning); foreach (var context in usedKeys.EmptyKeyContexts) emitWarning($"Empty key in map translation files required by {context}"); var mapTranslations = FieldLoader.GetValue("value", map.TranslationDefinitions.Value); foreach (var language in GetTranslationLanguages(modData)) { // Check keys and variables are not missing across all language files. // But for maps we don't warn on unused keys. They might be unused on *this* map, // but the mod or another map may use them and we don't have sight of that. CheckKeys( modData.Manifest.Translations.Concat(mapTranslations), map.Open, usedKeys, language, _ => false, emitError, emitWarning); var modTranslation = new Translation(language, modData.Manifest.Translations, modData.DefaultFileSystem, _ => { }); var mapTranslation = new Translation(language, mapTranslations, map, error => emitError(error.Message)); foreach (var group in usedKeys.KeysWithContext) { if (modTranslation.HasMessage(group.Key)) { if (mapTranslation.HasMessage(group.Key)) emitWarning($"Key `{group.Key}` in `{language}` language in map translation files already exists in mod translations and will not be used."); } else if (!mapTranslation.HasMessage(group.Key)) { foreach (var context in group) emitWarning($"Missing key `{group.Key}` in `{language}` language in map translation files required by {context}"); } } } } void ILintPass.Run(Action emitError, Action emitWarning, ModData modData) { var (usedKeys, testedFields) = GetUsedTranslationKeysInMod(modData); foreach (var context in usedKeys.EmptyKeyContexts) emitWarning($"Empty key in mod translation files required by {context}"); foreach (var language in GetTranslationLanguages(modData)) { Console.WriteLine($"Testing translation: {language}"); var translation = new Translation(language, modData.Manifest.Translations, modData.DefaultFileSystem, error => emitError(error.Message)); CheckModWidgets(modData, usedKeys, testedFields); // With the fully populated keys, check keys and variables are not missing and not unused across all language files. var keyWithAttrs = CheckKeys( modData.Manifest.Translations, modData.DefaultFileSystem.Open, usedKeys, language, file => !modData.Manifest.AllowUnusedTranslationsInExternalPackages || !modData.DefaultFileSystem.IsExternalFile(file), emitError, emitWarning); foreach (var group in usedKeys.KeysWithContext) { if (keyWithAttrs.Contains(group.Key)) continue; foreach (var context in group) emitWarning($"Missing key `{group.Key}` in `{language}` language in mod translation files required by {context}"); } } // Check if we couldn't test any fields. const BindingFlags Binding = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static; var allTranslatableFields = modData.ObjectCreator.GetTypes().SelectMany(t => t.GetFields(Binding).Where(m => Utility.HasAttribute(m))).ToArray(); var untestedFields = allTranslatableFields.Except(testedFields); foreach (var field in untestedFields) emitError( $"Lint pass ({nameof(CheckTranslationReference)}) lacks the know-how to test translatable field " + $"`{field.ReflectedType.Name}.{field.Name}` - previous warnings may be incorrect"); } static IEnumerable GetTranslationLanguages(ModData modData) { return modData.Manifest.Translations .Select(filename => TranslationFilenameRegex.Match(filename).Groups["language"].Value) .Distinct() .OrderBy(l => l); } static TranslationKeys GetUsedTranslationKeysInRuleset(Ruleset rules) { var usedKeys = new TranslationKeys(); foreach (var actorInfo in rules.Actors) { foreach (var traitInfo in actorInfo.Value.TraitInfos()) { var traitType = traitInfo.GetType(); foreach (var field in Utility.GetFields(traitType)) { var translationReference = Utility.GetCustomAttributes(field, true).SingleOrDefault(); if (translationReference == null) continue; foreach (var key in LintExts.GetFieldValues(traitInfo, field, translationReference.DictionaryReference)) usedKeys.Add(key, translationReference, $"Actor `{actorInfo.Key}` trait `{traitType.Name[..^4]}.{field.Name}`"); } } } return usedKeys; } static TranslationKeys GetUsedTranslationKeysInMap(Map map, Action emitWarning) { var usedKeys = GetUsedTranslationKeysInRuleset(map.Rules); var luaScriptInfo = map.Rules.Actors[SystemActors.World].TraitInfoOrDefault(); if (luaScriptInfo != null) { // Matches expressions such as: // UserInterface.Translate("translation-key") // UserInterface.Translate("translation-key\"with-escape") // UserInterface.Translate("translation-key", { ["attribute"] = foo }) // UserInterface.Translate("translation-key", { ["attribute\"-with-escape"] = foo }) // UserInterface.Translate("translation-key", { ["attribute1"] = foo, ["attribute2"] = bar }) // UserInterface.Translate("translation-key", tableVariable) // Extracts groups for the 'key' and each 'attr'. // If the table isn't inline like in the last example, extracts it as 'variable'. const string UserInterfaceTranslatePattern = @"UserInterface\s*\.\s*Translate\s*\(" + // UserInterface.Translate( @"\s*""(?(?:[^""\\]|\\.)+?)""\s*" + // "translation-key" @"(,\s*({\s*\[\s*""(?(?:[^""\\]|\\.)*?)""\s*\]\s*=\s*.*?" + // { ["attribute1"] = foo @"(\s*,\s*\[\s*""(?(?:[^""\\]|\\.)*?)""\s*\]\s*=\s*.*?)*\s*}\s*)" + // , ["attribute2"] = bar } "|\\s*,\\s*(?.*?))?" + // tableVariable @"\)"; // ) var translateRegex = new Regex(UserInterfaceTranslatePattern); // The script in mods/common/scripts/utils.lua defines some helpers which accept a translation key // Matches expressions such as: // AddPrimaryObjective(Player, "translation-key") // AddSecondaryObjective(Player, "translation-key") // AddPrimaryObjective(Player, "translation-key\"with-escape") // Extracts groups for the 'key'. const string AddObjectivePattern = @"(AddPrimaryObjective|AddSecondaryObjective)\s*\(" + // AddPrimaryObjective( @".*?\s*,\s*""(?(?:[^""\\]|\\.)+?)""\s*" + // Player, "translation-key" @"\)"; // ) var objectiveRegex = new Regex(AddObjectivePattern); foreach (var script in luaScriptInfo.Scripts) { if (!map.TryOpen(script, out var scriptStream)) continue; using (scriptStream) { var scriptText = scriptStream.ReadAllText(); IEnumerable matches = translateRegex.Matches(scriptText); if (luaScriptInfo.Scripts.Contains("utils.lua")) matches = matches.Concat(objectiveRegex.Matches(scriptText)); var scriptTranslations = matches.Select(m => { var key = m.Groups["key"].Value.Replace(@"\""", @""""); var attrs = m.Groups["attr"].Captures.Select(c => c.Value.Replace(@"\""", @"""")).ToArray(); var variable = m.Groups["variable"].Value; var line = scriptText.Take(m.Index).Count(x => x == '\n') + 1; return (Key: key, Attrs: attrs, Variable: variable, Line: line); }).ToArray(); foreach (var (key, attrs, variable, line) in scriptTranslations) { var context = $"Script {script}:{line}"; usedKeys.Add(key, new TranslationReferenceAttribute(attrs), context); if (variable != "") { var userInterface = typeof(UserInterfaceGlobal).GetCustomAttribute().Name; const string Translate = nameof(UserInterfaceGlobal.Translate); emitWarning($"{context} calls {userInterface}.{Translate} with key `{key}` and translate args passed as `{variable}`. Inline the args at the callsite for lint analysis."); } } } } } return usedKeys; } static (TranslationKeys UsedKeys, List TestedFields) GetUsedTranslationKeysInMod(ModData modData) { var usedKeys = GetUsedTranslationKeysInRuleset(modData.DefaultRules); var testedFields = new List(); testedFields.AddRange( modData.ObjectCreator.GetTypes() .Where(t => t.IsSubclassOf(typeof(TraitInfo))) .SelectMany(t => t.GetFields().Where(f => f.HasAttribute()))); // HACK: Need to hardcode the custom loader for GameSpeeds. var gameSpeeds = modData.Manifest.Get(); var gameSpeedNameField = typeof(GameSpeed).GetField(nameof(GameSpeed.Name)); var gameSpeedTranslationReference = Utility.GetCustomAttributes(gameSpeedNameField, true)[0]; testedFields.Add(gameSpeedNameField); foreach (var speed in gameSpeeds.Speeds.Values) usedKeys.Add(speed.Name, gameSpeedTranslationReference, $"`{nameof(GameSpeed)}.{nameof(GameSpeed.Name)}`"); // TODO: linter does not work with LoadUsing foreach (var actorInfo in modData.DefaultRules.Actors) { foreach (var info in actorInfo.Value.TraitInfos()) { var resourceTypeNameField = typeof(ResourceRendererInfo.ResourceTypeInfo).GetField(nameof(ResourceRendererInfo.ResourceTypeInfo.Name)); var resourceTypeTranslationReference = Utility.GetCustomAttributes(resourceTypeNameField, true)[0]; testedFields.Add(resourceTypeNameField); foreach (var resourceTypes in info.ResourceTypes) usedKeys.Add( resourceTypes.Value.Name, resourceTypeTranslationReference, $"`{nameof(ResourceRendererInfo.ResourceTypeInfo)}.{nameof(ResourceRendererInfo.ResourceTypeInfo.Name)}`"); } } foreach (var modType in modData.ObjectCreator.GetTypes()) { const BindingFlags Binding = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static; foreach (var field in modType.GetFields(Binding)) { // Checking for constant string fields. if (!field.IsLiteral) continue; var translationReference = Utility.GetCustomAttributes(field, true).SingleOrDefault(); if (translationReference == null) continue; testedFields.Add(field); var keys = LintExts.GetFieldValues(null, field, translationReference.DictionaryReference); foreach (var key in keys) usedKeys.Add(key, translationReference, $"`{field.ReflectedType.Name}.{field.Name}`"); } } return (usedKeys, testedFields); } static void CheckModWidgets(ModData modData, TranslationKeys usedKeys, List testedFields) { var chromeLayoutNodes = BuildChromeTree(modData); var widgetTypes = modData.ObjectCreator.GetTypes() .Where(t => t.Name.EndsWith("Widget", StringComparison.InvariantCulture) && t.IsSubclassOf(typeof(Widget))) .ToList(); var translationReferencesByWidgetField = widgetTypes.SelectMany(t => { var widgetName = t.Name[..^6]; return Utility.GetFields(t) .Select(f => { var attribute = Utility.GetCustomAttributes(f, true).SingleOrDefault(); return (WidgetName: widgetName, FieldName: f.Name, TranslationReference: attribute); }) .Where(x => x.TranslationReference != null); }) .ToDictionary( x => (x.WidgetName, x.FieldName), x => x.TranslationReference); testedFields.AddRange(widgetTypes.SelectMany( t => Utility.GetFields(t).Where(Utility.HasAttribute))); foreach (var node in chromeLayoutNodes) CheckChrome(node, translationReferencesByWidgetField, usedKeys); } static MiniYamlNode[] BuildChromeTree(ModData modData) { // Gather all the nodes together for evaluation. var chromeLayoutNodes = modData.Manifest.ChromeLayout .SelectMany(filename => MiniYaml.FromStream(modData.DefaultFileSystem.Open(filename), filename)) .ToArray(); return chromeLayoutNodes; } static void CheckChrome( MiniYamlNode rootNode, Dictionary<(string WidgetName, string FieldName), TranslationReferenceAttribute> translationReferencesByWidgetField, TranslationKeys usedKeys) { var nodeType = rootNode.Key.Split('@')[0]; foreach (var childNode in rootNode.Value.Nodes) { var childType = childNode.Key.Split('@')[0]; if (!translationReferencesByWidgetField.TryGetValue((nodeType, childType), out var translationReference)) continue; var key = childNode.Value.Value; usedKeys.Add(key, translationReference, $"Widget `{rootNode.Key}` field `{childType}` in {rootNode.Location}"); } foreach (var childNode in rootNode.Value.Nodes) if (childNode.Key == "Children") foreach (var n in childNode.Value.Nodes) CheckChrome(n, translationReferencesByWidgetField, usedKeys); } static HashSet CheckKeys( IEnumerable translationFiles, Func openFile, TranslationKeys usedKeys, string language, Func checkUnusedKeysForFile, Action emitError, Action emitWarning) { var keyWithAttrs = new HashSet(); foreach (var file in translationFiles) { if (!file.EndsWith($"{language}.ftl", StringComparison.Ordinal)) continue; var stream = openFile(file); using (var reader = new StreamReader(stream)) { var parser = new LinguiniParser(reader); var result = parser.Parse(); foreach (var entry in result.Entries) { if (entry is not AstMessage message) continue; IEnumerable<(Pattern Node, string AttributeName)> nodeAndAttributeNames; if (message.Attributes.Count == 0) nodeAndAttributeNames = new[] { (message.Value, (string)null) }; else nodeAndAttributeNames = message.Attributes.Select(a => (a.Value, a.Id.Name.ToString())); var key = message.GetId(); foreach (var (node, attributeName) in nodeAndAttributeNames) { keyWithAttrs.Add(attributeName == null ? key : $"{key}.{attributeName}"); if (checkUnusedKeysForFile(file)) CheckUnusedKey(key, attributeName, file, usedKeys, emitWarning); CheckVariables(node, key, attributeName, file, usedKeys, emitError, emitWarning); } } } } return keyWithAttrs; static void CheckUnusedKey(string key, string attribute, string file, TranslationKeys usedKeys, Action emitWarning) { var isAttribute = !string.IsNullOrEmpty(attribute); var keyWithAtrr = isAttribute ? $"{key}.{attribute}" : key; if (!usedKeys.Contains(keyWithAtrr)) emitWarning(isAttribute ? $"Unused attribute `{attribute}` of key `{key}` in {file}" : $"Unused key `{key}` in {file}"); } static void CheckVariables( Pattern node, string key, string attribute, string file, TranslationKeys usedKeys, Action emitError, Action emitWarning) { var isAttribute = !string.IsNullOrEmpty(attribute); var keyWithAtrr = isAttribute ? $"{key}.{attribute}" : key; if (!usedKeys.TryGetRequiredVariables(keyWithAtrr, out var requiredVariables)) return; var variableNames = new HashSet(); foreach (var element in node.Elements) { if (element is not Placeable placeable) continue; AddVariableAndCheckUnusedVariable(placeable); if (placeable.Expression is SelectExpression selectExpression) foreach (var variant in selectExpression.Variants) foreach (var variantElement in variant.Value.Elements) if (variantElement is Placeable variantPlaceable) AddVariableAndCheckUnusedVariable(variantPlaceable); } void AddVariableAndCheckUnusedVariable(Placeable placeable) { if (placeable.Expression is not IInlineExpression inlineExpression || inlineExpression is not VariableReference variableReference) return; var name = variableReference.Id.Name.ToString(); variableNames.Add(name); if (!requiredVariables.Contains(name)) emitWarning(isAttribute ? $"Unused variable `{name}` for attribute `{attribute}` of key `{key}` in {file}" : $"Unused variable `{name}` for key `{key}` in {file}"); } foreach (var name in requiredVariables) if (!variableNames.Contains(name)) emitError(isAttribute ? $"Missing variable `{name}` for attribute `{attribute}` of key `{key}` in {file}" : $"Missing variable `{name}` for key `{key}` in {file}"); } } class TranslationKeys { readonly HashSet keys = new(); readonly List<(string Key, string Context)> keysWithContext = new(); readonly Dictionary> requiredVariablesByKey = new(); readonly List contextForEmptyKeys = new(); public void Add(string key, TranslationReferenceAttribute translationReference, string context) { if (key == null) { if (!translationReference.Optional) contextForEmptyKeys.Add(context); return; } if (translationReference.RequiredVariableNames != null && translationReference.RequiredVariableNames.Length > 0) { var rv = requiredVariablesByKey.GetOrAdd(key, _ => new HashSet()); rv.UnionWith(translationReference.RequiredVariableNames); } keys.Add(key); keysWithContext.Add((key, context)); } public bool TryGetRequiredVariables(string key, out ISet requiredVariables) { if (requiredVariablesByKey.TryGetValue(key, out var rv)) { requiredVariables = rv; return true; } requiredVariables = null; return false; } public bool Contains(string key) { return keys.Contains(key); } public ILookup KeysWithContext => keysWithContext.OrderBy(x => x.Key).ToLookup(x => x.Key, x => x.Context); public IEnumerable EmptyKeyContexts => contextForEmptyKeys; } } }