If a class is caching the TraitsImplementing enumerable, instead cache the results of enumerating it to an array. The avoids having to enumerate the sequence each time it is needed.
47 lines
1.2 KiB
C#
47 lines
1.2 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2015 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation. For more information,
|
|
* see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using OpenRA.Activities;
|
|
using OpenRA.Traits;
|
|
|
|
namespace OpenRA.Mods.Common.Traits
|
|
{
|
|
[Desc("Actor has a visual turret used to attack.")]
|
|
public class AttackTurretedInfo : AttackFollowInfo, Requires<TurretedInfo>
|
|
{
|
|
public override object Create(ActorInitializer init) { return new AttackTurreted(init.Self, this); }
|
|
}
|
|
|
|
public class AttackTurreted : AttackFollow, ITick, ISync
|
|
{
|
|
protected Turreted[] turrets;
|
|
|
|
public AttackTurreted(Actor self, AttackTurretedInfo info)
|
|
: base(self, info)
|
|
{
|
|
turrets = self.TraitsImplementing<Turreted>().ToArray();
|
|
}
|
|
|
|
protected override bool CanAttack(Actor self, Target target)
|
|
{
|
|
if (!base.CanAttack(self, target))
|
|
return false;
|
|
|
|
foreach (var t in turrets)
|
|
if (t.FaceTarget(self, target))
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
}
|
|
}
|