7a7eed4fb7
This avoids the allocations caused by LINQ when using traits.FirstOrDefault(Exts.IsTraitEnabled). This is important in FrozenActorLayer.RefreshState which is called very often. We apply the new helper method to all areas using the old pattern. An overload that takes an array allows arrays to be enumerated without causing allocations.
36 lines
1.0 KiB
C#
36 lines
1.0 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2017 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation, either version 3 of
|
|
* the License, or (at your option) any later version. For more
|
|
* information, see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using OpenRA.Mods.Common.Traits;
|
|
using OpenRA.Traits;
|
|
|
|
namespace OpenRA.Mods.Common.Lint
|
|
{
|
|
class CheckTooltips : ILintRulesPass
|
|
{
|
|
public void Run(Action<string> emitError, Action<string> emitWarning, Ruleset rules)
|
|
{
|
|
foreach (var actorInfo in rules.Actors)
|
|
{
|
|
var buildable = actorInfo.Value.TraitInfoOrDefault<BuildableInfo>();
|
|
if (buildable == null)
|
|
continue;
|
|
|
|
var tooltip = actorInfo.Value.TraitInfos<TooltipInfo>().FirstEnabledTraitOrDefault();
|
|
if (tooltip == null)
|
|
emitError("The following buildable actor has no (enabled) Tooltip: " + actorInfo.Key);
|
|
}
|
|
}
|
|
}
|
|
}
|