949ba589c0
This changeset is motivated by a simple concept - get rid of the MiniYaml.Clone and MiniYamlNode.Clone methods to avoid deep copying yaml trees during merging. MiniYaml becoming immutable allows the merge function to reuse existing yaml trees rather than cloning them, saving on memory and improving merge performance. On initial loading the YAML for all maps is processed, so this provides a small reduction in initial loading time. The rest of the changeset is dealing with the change in the exposed API surface. Some With* helper methods are introduced to allow creating new YAML from existing YAML. Areas of code that generated small amounts of YAML are able to transition directly to the immutable model without too much ceremony. Some use cases are far less ergonomic even with these helper methods and so a MiniYamlBuilder is introduced to retain mutable creation functionality. This allows those areas to continue to use the old mutable structures. The main users are the update rules and linting capabilities.
117 lines
4.3 KiB
C#
117 lines
4.3 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright (c) The OpenRA Developers and Contributors
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation, either version 3 of
|
|
* the License, or (at your option) any later version. For more
|
|
* information, see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
|
|
namespace OpenRA.Mods.Common.UpdateRules.Rules
|
|
{
|
|
sealed class ReplaceFacingAngles : UpdateRule
|
|
{
|
|
static readonly Dictionary<string, string[]> TraitFields = new()
|
|
{
|
|
{ "Aircraft", new[] { "InitialFacing", "PreviewFacing", "TurnSpeed", "IdleTurnSpeed" } },
|
|
{ "Mobile", new[] { "InitialFacing", "PreviewFacing", "TurnSpeed" } },
|
|
{ "Husk", new[] { "PreviewFacing" } },
|
|
{ "Turreted", new[] { "InitialFacing", "TurnSpeed" } },
|
|
{ "GrantConditionOnDeploy", new[] { "Facing" } },
|
|
{ "FreeActor", new[] { "Facing" } },
|
|
{ "ProductionAirdrop", new[] { "Facing" } },
|
|
{ "EditorCursorLayer", new[] { "PreviewFacing" } },
|
|
{ "MPStartUnits", new[] { "BaseActorFacing", "SupportActorsFacing" } },
|
|
{ "Refinery", new[] { "DockAngle" } },
|
|
{ "Cargo", new[] { "PassengerFacing" } },
|
|
{ "Exit", new[] { "Facing" } },
|
|
{ "ThrowsParticle", new[] { "TurnSpeed" } },
|
|
{ "Transforms", new[] { "Facing" } },
|
|
{ "FallsToEarth", new[] { "MaximumSpinSpeed" } },
|
|
{ "ConyardChronoReturn", new[] { "Facing" } },
|
|
{ "TDGunboat", new[] { "InitialFacing", "PreviewFacing" } },
|
|
{ "DropPodsPower", new[] { "PodFacing" } },
|
|
{ "TiberianSunRefinery", new[] { "DockAngle" } },
|
|
{ "AttackAircraft", new[] { "FacingTolerance" } },
|
|
{ "AttackBomber", new[] { "FacingTolerance" } },
|
|
{ "AttackCharges", new[] { "FacingTolerance" } },
|
|
{ "AttackFollow", new[] { "FacingTolerance" } },
|
|
{ "AttackFrontal", new[] { "FacingTolerance" } },
|
|
{ "AttackGarrisoned", new[] { "FacingTolerance" } },
|
|
{ "AttackOmni", new[] { "FacingTolerance" } },
|
|
{ "AttackTurreted", new[] { "FacingTolerance" } },
|
|
{ "AttackLeap", new[] { "FacingTolerance" } },
|
|
{ "AttackPopupTurreted", new[] { "DefaultFacing", "FacingTolerance" } },
|
|
{ "AttackTDGunboatTurreted", new[] { "FacingTolerance" } },
|
|
{ "AttackTesla", new[] { "FacingTolerance" } },
|
|
};
|
|
|
|
static readonly Dictionary<string, string[]> ProjectileFields = new()
|
|
{
|
|
{ "Missile", new[] { "HorizontalRateOfTurn", "VerticalRateOfTurn" } }
|
|
};
|
|
|
|
public override string Name => "Increase facing angle resolution";
|
|
|
|
public override string Description
|
|
{
|
|
get
|
|
{
|
|
return "Trait fields that defined facings (0-255) have been replaced with higher resolution angles (0-1023).\n" +
|
|
"Values for the following trait fields should be multiplied by 4, or if undefined (-1) replaced by an empty definition:\n" +
|
|
UpdateUtils.FormatMessageList(TraitFields.Select(t => t.Key + "\n" + UpdateUtils.FormatMessageList(t.Value))) + "\n" +
|
|
"Values for the following projectile files should be multiplied by 4:\n" +
|
|
UpdateUtils.FormatMessageList(ProjectileFields.Select(t => t.Key + "\n" + UpdateUtils.FormatMessageList(t.Value)));
|
|
}
|
|
}
|
|
|
|
public override IEnumerable<string> UpdateActorNode(ModData modData, MiniYamlNodeBuilder actorNode)
|
|
{
|
|
foreach (var kv in TraitFields)
|
|
{
|
|
foreach (var traitNode in actorNode.ChildrenMatching(kv.Key))
|
|
{
|
|
foreach (var fieldName in kv.Value)
|
|
{
|
|
foreach (var fieldNode in traitNode.ChildrenMatching(fieldName))
|
|
{
|
|
var value = fieldNode.NodeValue<int>();
|
|
fieldNode.Value.Value = value != -1 ? FieldSaver.FormatValue(value != 255 ? 4 * value : 1023) : "";
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
yield break;
|
|
}
|
|
|
|
public override IEnumerable<string> UpdateWeaponNode(ModData modData, MiniYamlNodeBuilder weaponNode)
|
|
{
|
|
foreach (var projectileNode in weaponNode.ChildrenMatching("Projectile"))
|
|
{
|
|
if (projectileNode.Value.Value == null)
|
|
continue;
|
|
|
|
if (ProjectileFields.TryGetValue(projectileNode.Value.Value, out var fieldNames))
|
|
{
|
|
foreach (var fieldName in fieldNames)
|
|
{
|
|
foreach (var fieldNode in projectileNode.ChildrenMatching(fieldName))
|
|
{
|
|
var value = fieldNode.NodeValue<int>();
|
|
fieldNode.Value.Value = FieldSaver.FormatValue(value != 255 ? 4 * value : 1023);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
yield break;
|
|
}
|
|
}
|
|
}
|