- Rename the filename parameter to name and make it mandatory. Review all callers and ensure a useful string is provided as input, to ensure sufficient context is included for logging and debugging. This can be a filename, url, or any arbitrary text so include whatever context seems reasonable. - When several MiniYamls are created that have similar content, provide a shared string pool. This allows strings that are common between all the yaml to be shared, reducing long term memory usage. We also change the pool from a dictionary to a set. Originally a Dictionary had to be used so we could call TryGetValue to get a reference to the pooled string. Now that more recent versions of dotnet provide a TryGetValue on HashSet, we can use a set directly without the memory wasted by having to store both keys and values in a dictionary.
50 lines
1.3 KiB
C#
50 lines
1.3 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright (c) The OpenRA Developers and Contributors
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation, either version 3 of
|
|
* the License, or (at your option) any later version. For more
|
|
* information, see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
|
|
namespace OpenRA.Widgets
|
|
{
|
|
public static class ChromeMetrics
|
|
{
|
|
static Dictionary<string, string> data = new();
|
|
|
|
public static void Initialize(ModData modData)
|
|
{
|
|
var stringPool = new HashSet<string>(); // Reuse common strings in YAML
|
|
var metrics = MiniYaml.Merge(modData.Manifest.ChromeMetrics.Select(
|
|
y => MiniYaml.FromStream(modData.DefaultFileSystem.Open(y), y, stringPool: stringPool)));
|
|
data = new Dictionary<string, string>();
|
|
foreach (var m in metrics)
|
|
foreach (var n in m.Value.Nodes)
|
|
data[n.Key] = n.Value.Value;
|
|
}
|
|
|
|
public static T Get<T>(string key)
|
|
{
|
|
return FieldLoader.GetValue<T>(key, data[key]);
|
|
}
|
|
|
|
public static bool TryGet<T>(string key, out T result)
|
|
{
|
|
if (!data.TryGetValue(key, out var s))
|
|
{
|
|
result = default;
|
|
return false;
|
|
}
|
|
|
|
result = FieldLoader.GetValue<T>(key, s);
|
|
return true;
|
|
}
|
|
}
|
|
}
|