- Made private methods static where possible (runtime can elide checking the object for null). - Declared attribute classes as sealed (allows reflection on attributes to complete faster). - Moved some static cctor's into field initializers (static cctor's are slower than static field initializers). - Made classes static if they contained only static methods (can't create instances of useless objects). - Use inferable Exts.Lazy and not new Lazy<T>(). - Added required STAThread attribute to CrashDialog. - Removed unused parameters in private methods. - Added Serializable attribute to exceptions. - Added parameter name in calls to ArgumentNullException. - Use of as operator instead of is + cast. - Changed (x as Foo).Bar anti-pattern into ((Foo)x).Bar. Results in sensible cast exceptions on error rather than null dereferences. - Removed unused method in NullShader.
44 lines
1.2 KiB
C#
44 lines
1.2 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2011 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation. For more information,
|
|
* see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using OpenRA.Traits;
|
|
|
|
namespace OpenRA.Mods.RA
|
|
{
|
|
class RevealMapCrateActionInfo : CrateActionInfo
|
|
{
|
|
public readonly bool IncludeAllies = false;
|
|
public override object Create(ActorInitializer init) { return new RevealMapCrateAction(init.self, this); }
|
|
}
|
|
|
|
class RevealMapCrateAction : CrateAction
|
|
{
|
|
public RevealMapCrateAction(Actor self, RevealMapCrateActionInfo info)
|
|
: base(self, info) {}
|
|
|
|
bool ShouldReveal(Player collectingPlayer)
|
|
{
|
|
if (((RevealMapCrateActionInfo)info).IncludeAllies)
|
|
return collectingPlayer.World.LocalPlayer != null &&
|
|
collectingPlayer.Stances[collectingPlayer.World.LocalPlayer] == Stance.Ally;
|
|
|
|
return collectingPlayer == collectingPlayer.World.LocalPlayer;
|
|
}
|
|
|
|
public override void Activate(Actor collector)
|
|
{
|
|
base.Activate(collector);
|
|
|
|
if (ShouldReveal( collector.Owner ))
|
|
collector.Owner.Shroud.ExploreAll(collector.World);
|
|
}
|
|
}
|
|
}
|