- Made private methods static where possible (runtime can elide checking the object for null). - Declared attribute classes as sealed (allows reflection on attributes to complete faster). - Moved some static cctor's into field initializers (static cctor's are slower than static field initializers). - Made classes static if they contained only static methods (can't create instances of useless objects). - Use inferable Exts.Lazy and not new Lazy<T>(). - Added required STAThread attribute to CrashDialog. - Removed unused parameters in private methods. - Added Serializable attribute to exceptions. - Added parameter name in calls to ArgumentNullException. - Use of as operator instead of is + cast. - Changed (x as Foo).Bar anti-pattern into ((Foo)x).Bar. Results in sensible cast exceptions on error rather than null dereferences. - Removed unused method in NullShader.
39 lines
1.1 KiB
C#
39 lines
1.1 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2011 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation. For more information,
|
|
* see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System.Linq;
|
|
|
|
namespace OpenRA.Mods.RA.Crates
|
|
{
|
|
class GiveMcvCrateActionInfo : GiveUnitCrateActionInfo
|
|
{
|
|
public int NoBaseSelectionShares = 1000;
|
|
public override object Create(ActorInitializer init) { return new GiveMcvCrateAction(init.self, this); }
|
|
}
|
|
|
|
class GiveMcvCrateAction : GiveUnitCrateAction
|
|
{
|
|
public GiveMcvCrateAction(Actor self, GiveMcvCrateActionInfo info)
|
|
: base(self, info) { }
|
|
|
|
public override int GetSelectionShares(Actor collector)
|
|
{
|
|
if (!CanGiveTo(collector))
|
|
return 0; // there's some other really good reason why we shouldn't give this.
|
|
|
|
var hasBase = self.World.ActorsWithTrait<BaseBuilding>()
|
|
.Any(a => a.Actor.Owner == collector.Owner);
|
|
|
|
return hasBase ? info.SelectionShares :
|
|
((GiveMcvCrateActionInfo)info).NoBaseSelectionShares;
|
|
}
|
|
}
|
|
}
|