82bea961ba
- Made Array.IndexOf available via extension method. - Made ToHashSet extension method. - Change collections queried often via Contains into sets. - Avoid Count() extension if Count or Length property exist. - Made Count() > 0 checks and variations calls to Any() instead. - Don't call ToList/ToArray if there is no benefit to materializing the sequence. - If the sequence does benefit from materialization, follow this general pattern: - Collection queried often via Contains use ToHashSet to speed up lookups. - Short lived variables use ToList. This is because ToArray requires an extra copy to output the final size. - Collections persisted into fields or for a long time use ToArray to minimize memory overhead.
34 lines
981 B
C#
34 lines
981 B
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2015 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation. For more information,
|
|
* see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using OpenRA.Traits;
|
|
|
|
namespace OpenRA.Mods.Common.Lint
|
|
{
|
|
public class CheckTraitPrerequisites : ILintPass
|
|
{
|
|
public void Run(Action<string> emitError, Action<string> emitWarning, Map map)
|
|
{
|
|
foreach (var actorInfo in map.Rules.Actors.Where(a => !a.Key.StartsWith("^")))
|
|
try
|
|
{
|
|
var hasTraits = actorInfo.Value.TraitsInConstructOrder().Any();
|
|
if (!hasTraits)
|
|
emitWarning("Actor {0} has no traits. Is this intended?".F(actorInfo.Key));
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
emitError("Actor {0} is not constructible; failure: {1}".F(actorInfo.Key, e.Message));
|
|
}
|
|
}
|
|
}
|
|
} |