From 6e925c9a851d919dca4cda04678a246ab7ff2cda Mon Sep 17 00:00:00 2001 From: Marcos Lilljedahl Date: Sat, 24 Feb 2018 12:45:41 -0300 Subject: [PATCH] Fix print formatting errors --- docker/factory.go | 2 +- handlers/new_session.go | 2 +- pwd/instance_test.go | 1 - scheduler/scheduler.go | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/docker/factory.go b/docker/factory.go index 95bd12e..ea278d9 100644 --- a/docker/factory.go +++ b/docker/factory.go @@ -63,7 +63,7 @@ func NewClient(instance *types.Instance, proxyHost string) (*client.Client, erro dc, err := client.NewClient(durl, api.DefaultVersion, cli, nil) if err != nil { - return nil, fmt.Errorf("Could not connect to DinD docker daemon", err) + return nil, fmt.Errorf("Could not connect to DinD docker daemon: %v", err) } return dc, nil diff --git a/handlers/new_session.go b/handlers/new_session.go index ff5e684..1f01a39 100644 --- a/handlers/new_session.go +++ b/handlers/new_session.go @@ -68,7 +68,7 @@ func NewSession(rw http.ResponseWriter, req *http.Request) { return } if d > playground.DefaultSessionDuration { - log.Printf("Specified session duration was %s but maximum allowed by this playground is %d\n", d.String(), playground.DefaultSessionDuration.String()) + log.Printf("Specified session duration was %s but maximum allowed by this playground is %s\n", d.String(), playground.DefaultSessionDuration.String()) rw.WriteHeader(http.StatusBadRequest) return } diff --git a/pwd/instance_test.go b/pwd/instance_test.go index ca93f8c..8f40250 100644 --- a/pwd/instance_test.go +++ b/pwd/instance_test.go @@ -207,7 +207,6 @@ func TestInstanceNew_WithCustomHostname(t *testing.T) { _s.On("SessionCount").Return(1, nil) _s.On("ClientCount").Return(0, nil) _s.On("InstanceCount").Return(0, nil) - _s.On("InstanceFindBySessionId", "aaaabbbbcccc").Return([]*types.Instance{}, nil) var nilArgs []interface{} _e.M.On("Emit", event.SESSION_NEW, "aaaabbbbcccc", nilArgs).Return() diff --git a/scheduler/scheduler.go b/scheduler/scheduler.go index 6a621cb..18f89d8 100644 --- a/scheduler/scheduler.go +++ b/scheduler/scheduler.go @@ -275,7 +275,7 @@ func (s *scheduler) Start() error { if _, found := s.playgrounds[session.PlaygroundId]; !found { playground, err := s.storage.PlaygroundGet(session.PlaygroundId) if err != nil { - log.Printf("Could not find playground %s\n") + log.Printf("Could not find playground %s\n", session.PlaygroundId) return } s.playgrounds[playground.Id] = playground