Don't flash bibs when targeting buildings.

2013-08-11 16:39:18 +12:00
parent 190ce0fc90
commit 0b1ce8097f
1 changed files with 8 additions and 5 deletions
--- a/OpenRA.Game/Effects/FlashTarget.cs
+++ b/OpenRA.Game/Effects/FlashTarget.cs
@@ -35,12 +35,15 @@ namespace OpenRA.Effects

 		public IEnumerable<IRenderable> Render(WorldRenderer wr)
 		{
-			if (!target.IsInWorld)
-				yield break;
+			if (target.IsInWorld && remainingTicks % 2 == 0)
+			{
+				var palette = wr.Palette("highlight");
+				return target.Render(wr)
+					.Where(r => !r.IsDecoration)
+					.Select(r => r.WithPalette(palette));
+			}

-			if (remainingTicks % 2 == 0)
-				foreach (var r in target.Render(wr))
-					yield return r.WithPalette(wr.Palette("highlight"));
+			return SpriteRenderable.None;
 		}
 	}
 }