epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid unnecessary trait lookups

Browse Source
This commit is contained in:
Matthias Mailänder
2015-08-29 18:58:30 +02:00
parent 1dfb982d6f
commit 25a0143b46
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
OpenRA.Mods.Common/Traits/BodyOrientation.cs
View File

@@ -73,12 +73,11 @@ namespace OpenRA.Mods.Common.Traits
return info.QuantizedFacings; return info.QuantizedFacings;
var qboi = self.Info.Traits.GetOrDefault<IQuantizeBodyOrientationInfo>(); var qboi = self.Info.Traits.GetOrDefault<IQuantizeBodyOrientationInfo>();
var isb = self.HasTrait<ISpriteBody>();
// If a sprite actor has neither custom QuantizedFacings nor a trait implementing IQuantizeBodyOrientationInfo, throw // If a sprite actor has neither custom QuantizedFacings nor a trait implementing IQuantizeBodyOrientationInfo, throw
if (qboi == null) if (qboi == null)
{ {
if (isb) if (self.HasTrait<ISpriteBody>())
throw new InvalidOperationException("Actor" + self.Info.Name + "has a sprite body but no facing quantization." throw new InvalidOperationException("Actor" + self.Info.Name + "has a sprite body but no facing quantization."
+ " Either add the QuantizeFacingsFromSequence trait or set custom QuantizedFacings on BodyOrientation."); + " Either add the QuantizeFacingsFromSequence trait or set custom QuantizedFacings on BodyOrientation.");
else else