epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant jumps and other style nits from the update rules

Browse Source
This commit is contained in:
abcdefg30
2023-02-17 21:50:25 +01:00
committed by Pavel Penev
parent 947f53a991
commit 4a554431ff
8 changed files with 2 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenRA.Mods.Common/UpdateRules/Rules/20200202/RemoveInitialFacingHardcoding.cs
View File

@@ -53,8 +53,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
nonVTOLs.Add(Tuple.Create(actorNode.Key, actorNode.Location.Filename)); nonVTOLs.Add(Tuple.Create(actorNode.Key, actorNode.Location.Filename));
} }
yield break;
} }
} }
} }

5
OpenRA.Mods.Common/UpdateRules/Rules/20200503/ChangeTargetLineDelayToMilliseconds.cs
View File

@@ -26,12 +26,9 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
foreach (var dltt in actorNode.ChildrenMatching("DrawLineToTarget", includeRemovals: false)) foreach (var dltt in actorNode.ChildrenMatching("DrawLineToTarget", includeRemovals: false))
{ {
var delayNode = dltt.LastChildMatching("Delay", false); var delayNode = dltt.LastChildMatching("Delay", false);
if (delayNode != null) if (delayNode != null && Exts.TryParseIntegerInvariant(delayNode.Value.Value, out var delay))
{
if (Exts.TryParseIntegerInvariant(delayNode.Value.Value, out var delay))
delayNode.ReplaceValue((delay * 1000 / 25).ToString()); delayNode.ReplaceValue((delay * 1000 / 25).ToString());
} }
}
yield break; yield break;
} }

2
OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveTurnToDock.cs
View File

@@ -50,8 +50,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
turningAircraft.Add(Tuple.Create(actorNode.Key, actorNode.Location.Filename)); turningAircraft.Add(Tuple.Create(actorNode.Key, actorNode.Location.Filename));
} }
yield break;
} }
} }
} }

2
OpenRA.Mods.Common/UpdateRules/Rules/20200503/SplitDamagedByTerrain.cs
View File

@@ -28,8 +28,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
if (damaged.RemoveNodes("StartOnThreshold") > 0) if (damaged.RemoveNodes("StartOnThreshold") > 0)
yield return $"'StartOnThreshold' was removed from {actorNode.Key} ({actorNode.Location.Filename}) without replacement.\n"; yield return $"'StartOnThreshold' was removed from {actorNode.Key} ({actorNode.Location.Filename}) without replacement.\n";
} }
yield break;
} }
} }
} }

2
OpenRA.Mods.Common/UpdateRules/Rules/20210321/ReplaceCrateSecondsWithTicks.cs
View File

@@ -35,9 +35,7 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
} }
foreach (var scNode in actorNode.ChildrenMatching("ScaredyCat")) foreach (var scNode in actorNode.ChildrenMatching("ScaredyCat"))
{
scNode.RenameChildrenMatching("PanicLength", "PanicDuration"); scNode.RenameChildrenMatching("PanicLength", "PanicDuration");
}
yield break; yield break;
} }

2
OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs
View File

@@ -315,8 +315,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
foreach (var sequenceNode in imageNode.Value.Nodes.ToList()) foreach (var sequenceNode in imageNode.Value.Nodes.ToList())
if (implicitInheritedSequences.Contains(sequenceNode.Key) && !sequenceNode.Value.Nodes.Any()) if (implicitInheritedSequences.Contains(sequenceNode.Key) && !sequenceNode.Value.Nodes.Any())
imageNode.RemoveNode(sequenceNode); imageNode.RemoveNode(sequenceNode);
yield break;
} }
void ProcessNode(ModData modData, MiniYamlNode sequenceNode, MiniYamlNode resolvedSequenceNode, string imageName) void ProcessNode(ModData modData, MiniYamlNode sequenceNode, MiniYamlNode resolvedSequenceNode, string imageName)

4
OpenRA.Mods.Common/UpdateRules/Rules/20221203/ProductionTabsWidgetAddTabButtonCollection.cs
View File

@@ -33,11 +33,7 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
} }
if (buttonCollection != null) if (buttonCollection != null)
{
chromeNode.AddNode(new MiniYamlNode("ArrowButton", buttonCollection)); chromeNode.AddNode(new MiniYamlNode("ArrowButton", buttonCollection));
} }
yield break;
}
} }
} }

2
OpenRA.Mods.Common/UpdateRules/Rules/20221203/TextNotificationsDisplayWidgetRemoveTime.cs
View File

@@ -32,8 +32,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules
var durationMilliseconds = field.NodeValue<int>() * 40; var durationMilliseconds = field.NodeValue<int>() * 40;
field.ReplaceValue(FieldSaver.FormatValue(durationMilliseconds)); field.ReplaceValue(FieldSaver.FormatValue(durationMilliseconds));
} }
yield break;
} }
} }
} }