epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove lint rule for victim scan radii

Browse Source 
They're now calculated automatically to use the most sensible value by default. Only people who know what they're doing or fool around will use custom values, and in that case a lint rule might actually just annoy people.
This commit is contained in:
reaperrr
2017-01-15 12:00:23 +01:00
committed by Chris Forbes
parent 96d629cefd
commit 5b8c313d55
2 changed files with 0 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
OpenRA.Mods.Common/Lint/CheckTargetHealthRadius.cs
View File

@@ -1,92 +0,0 @@
#region Copyright & License Information
/*
* Copyright 2007-2017 The OpenRA Developers (see AUTHORS)
* This file is part of OpenRA, which is free software. It is made
* available to you under the terms of the GNU General Public License
* as published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version. For more
* information, see COPYING.
*/
#endregion
using System;
using System.Linq;
using OpenRA.Mods.Common.Projectiles;
using OpenRA.Mods.Common.Traits;
using OpenRA.Mods.Common.Warheads;
using OpenRA.Traits;
namespace OpenRA.Mods.Common.Lint
{
class CheckTargetHealthRadius : ILintRulesPass
{
public void Run(Action<string> emitError, Action<string> emitWarning, Ruleset rules)
{
foreach (var actorInfo in rules.Actors)
{
var healthTraits = actorInfo.Value.TraitInfos<HealthInfo>().ToList();
if (!healthTraits.Any())
continue;
var targetable = actorInfo.Value.TraitInfos<ITargetableInfo>().SelectMany(x => x.GetTargetTypes()).ToList();
if (!targetable.Any())
continue;
foreach (var weaponInfo in rules.Weapons)
{
var warheads = weaponInfo.Value.Warheads.OfType<SpreadDamageWarhead>().Where(dw => dw.Damage > 0);
foreach (var warhead in warheads)
{
// This is a special warhead, like the one on `weathering` in D2k.
if (!warhead.DamageTypes.Any())
continue;
// This warhead cannot affect this actor.
if (!warhead.ValidTargets.Overlaps(targetable))
continue;
if (healthTraits.Where(x => x.Shape.OuterRadius.Length > warhead.TargetExtraSearchRadius.Length).Any())
emitError("Actor type `{0}` has a health radius exceeding the victim scan radius of a SpreadDamageWarhead on `{1}`!"
.F(actorInfo.Key, weaponInfo.Key));
}
var effectWarheads = weaponInfo.Value.Warheads.OfType<CreateEffectWarhead>();
foreach (var warhead in effectWarheads)
{
// This warhead cannot affect this actor.
if (!warhead.ValidTargets.Overlaps(targetable))
continue;
if (healthTraits.Where(x => x.Shape.OuterRadius.Length > warhead.TargetSearchRadius.Length).Any())
emitError("Actor type `{0}` has a health radius exceeding the victim scan radius of a CreateEffectWarhead on `{1}`!"
.F(actorInfo.Key, weaponInfo.Key));
}
var bullet = weaponInfo.Value.Projectile as BulletInfo;
var missile = weaponInfo.Value.Projectile as MissileInfo;
var areabeam = weaponInfo.Value.Projectile as AreaBeamInfo;
if (bullet == null && missile == null && areabeam == null)
continue;
var targetExtraSearchRadius = WDist.Zero;
if (bullet != null)
targetExtraSearchRadius = bullet.TargetExtraSearchRadius;
if (missile != null)
targetExtraSearchRadius = missile.TargetExtraSearchRadius;
if (areabeam != null)
targetExtraSearchRadius = areabeam.TargetExtraSearchRadius;
if (healthTraits.Where(x => x.Shape.OuterRadius.Length > targetExtraSearchRadius.Length).Any())
emitError("Actor type `{0}` has a health radius exceeding the victim scan radius of the projectile on `{1}`!"
.F(actorInfo.Key, weaponInfo.Key));
}
}
}
}
}

1
OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
View File

@@ -181,7 +181,6 @@
<Compile Include="Lint\CheckRangeLimit.cs" /> <Compile Include="Lint\CheckRangeLimit.cs" />
<Compile Include="Lint\CheckVoiceReferences.cs" /> <Compile Include="Lint\CheckVoiceReferences.cs" />
<Compile Include="Lint\CheckConditions.cs" /> <Compile Include="Lint\CheckConditions.cs" />
<Compile Include="Lint\CheckTargetHealthRadius.cs" />
<Compile Include="Lint\LintBuildablePrerequisites.cs" /> <Compile Include="Lint\LintBuildablePrerequisites.cs" />
<Compile Include="Lint\LintExts.cs" /> <Compile Include="Lint\LintExts.cs" />
<Compile Include="LoadScreens\ModContentLoadScreen.cs" /> <Compile Include="LoadScreens\ModContentLoadScreen.cs" />