Fix RCS1227

This commit is contained in:
RoosterDragon
2023-08-11 19:44:06 +01:00
committed by Gustas
parent c4ca3ca743
commit 64de28427c
2 changed files with 13 additions and 5 deletions

View File

@@ -1109,6 +1109,9 @@ dotnet_diagnostic.RCS1225.severity = warning
# Add paragraph to documentation comment.
dotnet_diagnostic.RCS1226.severity = warning
# Validate arguments correctly.
dotnet_diagnostic.RCS1227.severity = warning
# Unnecessary explicit use of enumerator.
dotnet_diagnostic.RCS1230.severity = warning

View File

@@ -1353,13 +1353,18 @@ namespace OpenRA
throw new ArgumentOutOfRangeException(nameof(maxRange),
$"The requested range ({maxRange}) cannot exceed the value of MaximumTileSearchRange ({Grid.MaximumTileSearchRange})");
for (var i = minRange; i <= maxRange; i++)
return FindTilesInAnnulus();
IEnumerable<CPos> FindTilesInAnnulus()
{
foreach (var offset in Grid.TilesByDistance[i])
for (var i = minRange; i <= maxRange; i++)
{
var t = offset + center;
if (allowOutsideBounds ? Tiles.Contains(t) : Contains(t))
yield return t;
foreach (var offset in Grid.TilesByDistance[i])
{
var t = offset + center;
if (allowOutsideBounds ? Tiles.Contains(t) : Contains(t))
yield return t;
}
}
}
}