remove InvisibleToEnemy, use plain Cloak for mines

OpenRA.Mods.RA/InvisibleToEnemy.cs

@@ -1,46 +0,0 @@
-#region Copyright & License Information
-/*
- * Copyright 2007-2011 The OpenRA Developers (see AUTHORS)
- * This file is part of OpenRA, which is free software. It is made
- * available to you under the terms of the GNU General Public License
- * as published by the Free Software Foundation. For more information,
- * see COPYING.
- */
-#endregion
-
-using System.Collections.Generic;
-using System.Drawing;
-using OpenRA.Graphics;
-using OpenRA.Traits;
-
-namespace OpenRA.Mods.RA
-{
-	class InvisibleToEnemyInfo : TraitInfo<InvisibleToEnemy> { }
-
-	class InvisibleToEnemy : IRenderModifier, IVisibilityModifier, IRadarColorModifier
-	{
-		public bool IsVisible(Shroud s, Actor self)
-		{
-			if (s != null && s.Observing)
-				return true;
-
-			if (self.World.LocalPlayer != null && self.Owner.Stances[self.World.LocalPlayer] == Stance.Ally)
-				return true;
-
-			return false;
-		}
-
-		public Color RadarColorOverride(Actor self)
-		{
-			// TODO: why is making this half-opaque conflated with hiding the actor from non-allies?
-			return Color.FromArgb(128, self.Owner.ColorRamp.GetColor(0));
-		}
-
-		static readonly Renderable[] Nothing = { };
-
-		public IEnumerable<Renderable> ModifyRender(Actor self, WorldRenderer wr, IEnumerable<Renderable> r)
-		{
-			return IsVisible(self.World.RenderedShroud, self) ? r : Nothing;
-		}
-	}
-}

OpenRA.Mods.RA/OpenRA.Mods.RA.csproj

@@ -231,7 +231,6 @@
     <Compile Include="HarvesterHuskModifier.cs" />
     <Compile Include="Husk.cs" />
     <Compile Include="InfiltrateForSupportPower.cs" />
-    <Compile Include="InvisibleToEnemy.cs" />
     <Compile Include="Invulnerable.cs" />
     <Compile Include="IronCurtainable.cs" />
     <Compile Include="LeavesHusk.cs" />

mods/ra-classic/rules/system.yaml

@@ -250,7 +250,7 @@ MINP:
 		HP: 1
 	RenderSimple:
 	BelowUnits:
-	InvisibleToEnemy:
+	Cloak:
 	Tooltip:
 		Name: Anti-Personnel Mine
 		Icon: jmin
@@ -267,7 +267,7 @@ MINV:
 		HP: 1
 	RenderSimple:
 	BelowUnits:
-	InvisibleToEnemy:
+	Cloak:
 	Tooltip:
 		Name: Anti-Tank Mine
 		Icon: jmin

mods/ra/rules/system.yaml

@@ -636,7 +636,7 @@ MINP:
 		HP: 1
 	RenderSimple:
 	BelowUnits:
-	InvisibleToEnemy:
+	Cloak:
 	Tooltip:
 		Name: Anti-Personnel Mine
 		Icon: jmin
@@ -653,7 +653,7 @@ MINV:
 		HP: 1
 	RenderSimple:
 	BelowUnits:
-	InvisibleToEnemy:
+	Cloak:
 	Tooltip:
 		Name: Anti-Tank Mine
 		Icon: jmin