Merge pull request #3415 from pchote/remove-dead-external-connect

Remove Bitrotted JoinExternalGame.

OpenRA.Game/Game.cs

@@ -459,23 +459,6 @@ namespace OpenRA
 			return orderManager != null && orderManager.world == world;
 		}
 
-		public static void JoinExternalGame()
-		{
-			var addressParts = Game.Settings.Game.ConnectTo.Split(
-				new [] { ':' }, StringSplitOptions.RemoveEmptyEntries);
-
-			if (addressParts.Length < 1 || addressParts.Length > 2)
-				return;
-
-			var host = addressParts[0];
-			var port = Exts.WithDefault(1234, () => int.Parse(addressParts[1]));
-
-			Game.Settings.Game.ConnectTo = "";
-			Game.Settings.Save();
-
-			Game.JoinServer(host, port);
-		}
-
 		public static bool DownloadMap(string mapHash)
 		{
 			try

OpenRA.Game/GameRules/Settings.cs

@@ -130,7 +130,6 @@ namespace OpenRA.GameRules
 		// Internal game settings
 		public int Timestep = 40;
 
-		public string ConnectTo = "";
 		public bool AllowDownloading = true;
 		public string MapRepository = "http://content.open-ra.org/map/";
 	}

OpenRA.Mods.Cnc/CncLoadScreen.cs

@@ -120,7 +120,6 @@ namespace OpenRA.Mods.Cnc
 		public void StartGame()
 		{
 			TestAndContinue();
-			Game.JoinExternalGame();
 		}
 
 		void TestAndContinue()

OpenRA.Mods.D2k/D2kLoadScreen.cs

@@ -70,7 +70,6 @@ namespace OpenRA.Mods.D2k
 		public void StartGame()
 		{
 			TestAndContinue();
-			Game.JoinExternalGame();
 		}
 
 		void TestAndContinue()

OpenRA.Mods.RA/RALoadScreen.cs

@@ -74,7 +74,6 @@ namespace OpenRA.Mods.RA
 		public void StartGame()
 		{
 			TestAndContinue();
-			Game.JoinExternalGame();
 		}
 
 		void TestAndContinue()