epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PrimaryBuilding: Fix benign loop variable in closure hazard

Browse Source 
This never outlived a single loop iteration.
This commit is contained in:
Chris Forbes
2014-10-07 18:24:00 +13:00
parent f2492f4155
commit 98563eb854
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
OpenRA.Mods.RA/PrimaryBuilding.cs
View File

@@ -67,13 +67,16 @@ namespace OpenRA.Mods.RA
// TODO: THIS IS SHIT // TODO: THIS IS SHIT
// Cancel existing primaries // Cancel existing primaries
foreach (var p in self.Info.Traits.Get<ProductionInfo>().Produces) foreach (var p in self.Info.Traits.Get<ProductionInfo>().Produces)
{
var productionType = p; // benign closure hazard
foreach (var b in self.World foreach (var b in self.World
.ActorsWithTrait<PrimaryBuilding>() .ActorsWithTrait<PrimaryBuilding>()
.Where(a => .Where(a =>
a.Actor.Owner == self.Owner && a.Actor.Owner == self.Owner &&
a.Trait.IsPrimary && a.Trait.IsPrimary &&
a.Actor.Info.Traits.Get<ProductionInfo>().Produces.Contains(p))) a.Actor.Info.Traits.Get<ProductionInfo>().Produces.Contains(productionType)))
b.Trait.SetPrimaryProducer(b.Actor, false); b.Trait.SetPrimaryProducer(b.Actor, false);
}
isPrimary = true; isPrimary = true;