epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix IDE0075

Browse Source
This commit is contained in:
RoosterDragon
2023-02-19 12:35:15 +00:00
committed by Pavel Penev
parent 3402031399
commit 99c289e063
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.editorconfig
View File

@@ -201,6 +201,9 @@ dotnet_diagnostic.IDE0061.severity = warning
# Simplify interpolation.
dotnet_diagnostic.IDE0071.severity = warning
# Simplify conditional expression.
dotnet_diagnostic.IDE0075.severity = warning
# Naming rule violation.
dotnet_diagnostic.IDE1006.severity = warning

2
OpenRA.Mods.Cnc/Effects/GpsDotEffect.cs
View File

@@ -39,7 +39,7 @@ namespace OpenRA.Mods.Cnc.Effects
if (frozenLayer != null)
{
var frozenActor = frozenLayer.FromID(a.ActorID);
FrozenActorWithRenderables = frozenActor != null ? frozenActor.HasRenderables : false;
FrozenActorWithRenderables = frozenActor != null && frozenActor.HasRenderables;
}
}
}

2
OpenRA.Mods.Common/Traits/Palettes/PaletteFromGimpOrJascFile.cs
View File

@@ -89,7 +89,7 @@ namespace OpenRA.Mods.Common.Traits
// Check if color has a (valid) alpha value.
// Note: We can't throw on "rgba.Length > 3 but parse failed", because in GIMP palettes the 'invalid' value is probably a color name string.
var noAlpha = rgba.Length > 3 ? !byte.TryParse(rgba[3], out a) : true;
var noAlpha = rgba.Length <= 3 || !byte.TryParse(rgba[3], out a);
// Index should be completely transparent/background color
if (i == TransparentIndex)