epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wrap OpenRA arguments in quotes

Browse Source 
On Windows, if the path to the replay contained spaces, it wouldn't be parsed correctly and would crash the game.
This commit is contained in:
Alexandre Oliveira
2016-01-30 16:26:21 -02:00
parent c19383472f
commit bcb8daba84
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
OpenRA.GameMonitor/GameMonitor.cs
View File

@@ -12,6 +12,7 @@ using System;
using System.Diagnostics; using System.Diagnostics;
using System.Drawing; using System.Drawing;
using System.IO; using System.IO;
using System.Linq;
using System.Media; using System.Media;
using System.Reflection; using System.Reflection;
using System.Windows.Forms; using System.Windows.Forms;
@@ -30,7 +31,7 @@ namespace OpenRA
Directory.SetCurrentDirectory(executableDirectory); Directory.SetCurrentDirectory(executableDirectory);
var psi = new ProcessStartInfo(processName, string.Join(" ", args)); var psi = new ProcessStartInfo(processName, string.Join(" ", args.Select(arg => "\"" + arg + "\"")));
try try
{ {

2
packaging/windows/OpenRA.nsi
View File

@@ -59,7 +59,7 @@ Section "-Reg" Reg
; Replay file association ; Replay file association
WriteRegStr HKLM "Software\Classes\.orarep" "" "OpenRA_replay" WriteRegStr HKLM "Software\Classes\.orarep" "" "OpenRA_replay"
WriteRegStr HKLM "Software\Classes\OpenRA_replay\DefaultIcon" "" "$INSTDIR\OpenRA.ico,0" WriteRegStr HKLM "Software\Classes\OpenRA_replay\DefaultIcon" "" "$INSTDIR\OpenRA.ico,0"
WriteRegStr HKLM "Software\Classes\OpenRA_replay\Shell\Open\Command" "" "$INSTDIR\OpenRA.exe Launch.Replay=%1" WriteRegStr HKLM "Software\Classes\OpenRA_replay\Shell\Open\Command" "" "$INSTDIR\OpenRA.exe Launch.Replay=$\"%1$\""
; OpenRA URL Scheme ; OpenRA URL Scheme
WriteRegStr HKLM "Software\Classes\openra" "" "URL:OpenRA scheme" WriteRegStr HKLM "Software\Classes\openra" "" "URL:OpenRA scheme"