Some cleanups

OpenRA.Mods.Common/AI/AttackOrFleeFuzzy.cs

@@ -12,8 +12,8 @@ using System;
 using System.Collections.Generic;
 using System.Linq;
 using AI.Fuzzy.Library;
-using OpenRA.GameRules;
 using OpenRA.Mods.Common.Traits;
+using OpenRA.Mods.Common.Warheads;
 using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.AI
@@ -191,13 +191,13 @@ namespace OpenRA.Mods.Common.AI
 
 		protected float RelativePower(IEnumerable<Actor> own, IEnumerable<Actor> enemy)
 		{
-			return RelativeValue(own, enemy, 100, SumOfValues<AttackBase>, (Actor a) =>
+			return RelativeValue(own, enemy, 100, SumOfValues<AttackBase>, a =>
 			{
 				var sumOfDamage = 0;
 				var arms = a.TraitsImplementing<Armament>();
 				foreach (var arm in arms)
 				{
-					var warhead = arm.Weapon.Warheads.Select(w => w as DamageWarhead).FirstOrDefault(w => w != null);
+					var warhead = arm.Weapon.Warheads.OfType<DamageWarhead>().FirstOrDefault();
 					if (warhead != null)
 						sumOfDamage += warhead.Damage;
 				}

OpenRA.Mods.Common/Lint/CheckDeathTypes.cs

@@ -10,8 +10,8 @@
 
 using System;
 using System.Linq;
-using OpenRA.GameRules;
 using OpenRA.Mods.Common.Traits;
+using OpenRA.Mods.Common.Warheads;
 using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Lint

OpenRA.Mods.Common/Traits/Attack/AttackBase.cs

@@ -13,7 +13,7 @@ using System.Collections.Generic;
 using System.Drawing;
 using System.Linq;
 using OpenRA.Activities;
-using OpenRA.GameRules;
+using OpenRA.Mods.Common.Warheads;
 using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Traits
@@ -101,8 +101,11 @@ namespace OpenRA.Mods.Common.Traits
 		{
 			get
 			{
+				if (IsTraitDisabled)
+					yield break;
+
 				var armament = Armaments.FirstOrDefault(a => a.Weapon.Warheads.Any(w => (w is DamageWarhead)));
-				if (armament == null || IsTraitDisabled)
+				if (armament == null)
 					yield break;
 
 				var negativeDamage = (armament.Weapon.Warheads.FirstOrDefault(w => (w is DamageWarhead)) as DamageWarhead).Damage < 0;

OpenRA.Mods.Common/UtilityCommands/ActorStatsExport.cs

@@ -12,8 +12,8 @@ using System;
 using System.Collections.Generic;
 using System.Data;
 using System.Linq;
-using OpenRA.GameRules;
 using OpenRA.Mods.Common.Traits;
+using OpenRA.Mods.Common.Warheads;
 using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.UtilityCommands

OpenRA.Mods.Common/Warheads/HealthPercentageDamageWarhead.cs

@@ -8,11 +8,8 @@
  */
 #endregion
 
-using System;
 using System.Collections.Generic;
 using System.Linq;
-using OpenRA.Effects;
-using OpenRA.GameRules;
 using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Warheads

OpenRA.Mods.Common/Warheads/SpreadDamageWarhead.cs

@@ -10,9 +10,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using OpenRA.Effects;
-using OpenRA.GameRules;
 using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Warheads

OpenRA.Mods.D2k/Warheads/ChangeOwnerWarhead.cs

@@ -9,7 +9,7 @@
 #endregion
 
 using System.Collections.Generic;
-using OpenRA.GameRules;
+using OpenRA.Mods.Common.Warheads;
 using OpenRA.Mods.D2k.Traits;
 using OpenRA.Traits;
 
@@ -30,11 +30,12 @@ namespace OpenRA.Mods.D2k.Warheads
 
 			foreach (var a in actors)
 			{
-				if (a.Owner == firedBy.Owner) // don't do anything on friendly fire
+				// Don't do anything on friendly fire
+				if (a.Owner == firedBy.Owner)
 					continue;
 
 				if (Duration == 0)
-					a.ChangeOwner(firedBy.Owner); // permanent
+					a.ChangeOwner(firedBy.Owner); // Permanent
 				else
 				{
 					var tempOwnerManager = a.TraitOrDefault<TemporaryOwnerManager>();
@@ -44,7 +45,8 @@ namespace OpenRA.Mods.D2k.Warheads
 					tempOwnerManager.ChangeOwner(a, firedBy.Owner, Duration);
 				}
 
-				a.CancelActivity(); // stop shooting, you have got new enemies
+				// Stop shooting, you have new enemies
+				a.CancelActivity();
 			}
 		}
 	}