DefaultSpriteSequence: Avoid an extra allocation and LINQ when adding shadow frames

2023-05-16 19:37:01 +02:00
parent 05f21fcbe2
commit ce7f9e71c1
1 changed files with 6 additions and 1 deletions
--- a/OpenRA.Mods.Common/Graphics/DefaultSpriteSequence.cs
+++ b/OpenRA.Mods.Common/Graphics/DefaultSpriteSequence.cs
@@ -318,7 +318,12 @@ namespace OpenRA.Mods.Common.Graphics
 			}

 			if (shadowStart >= 0)
-				usedFrames.AddRange(usedFrames.ToList().Select(i => i + shadowStart - start));
+			{
+				var shadowOffset = shadowStart - start;
+				var frameCount = usedFrames.Count;
+				for (var i = 0; i < frameCount; i++)
+					usedFrames.Add(usedFrames[i] + shadowOffset);
+			}

 			return usedFrames;
 		}