epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove Game.Debug messages from ValidateOrder.

Browse Source
This commit is contained in:
Paul Chote
2019-01-19 19:15:26 +00:00
parent a2c6b19205
commit d379555784
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
OpenRA.Mods.Common/Traits/World/ValidateOrder.cs
View File

@@ -29,18 +29,17 @@ namespace OpenRA.Mods.Common.Traits
if (subjectClient == null) if (subjectClient == null)
{ {
Game.Debug("Order sent to {0}: resolved ClientIndex `{1}` doesn't exist", order.Subject.Owner.PlayerName, subjectClientId); Log.Write("debug", "Order sent to {0}: resolved ClientIndex `{1}` doesn't exist", order.Subject.Owner.PlayerName, subjectClientId);
return false; return false;
} }
var isBotOrder = subjectClient.Bot != null && clientId == subjectClient.BotControllerClientIndex; var isBotOrder = subjectClient.Bot != null && clientId == subjectClient.BotControllerClientIndex;
// Drop exploiting orders // Drop orders from players who shouldn't be able to control this actor
// This may be because the owner changed within the last net tick,
// or, less likely, the client may be trying to do something malicious.
if (subjectClientId != clientId && !isBotOrder) if (subjectClientId != clientId && !isBotOrder)
{
Game.Debug("Detected exploit order from client {0}: {1}", clientId, order.OrderString);
return false; return false;
}
return order.Subject.AcceptsOrder(order.OrderString); return order.Subject.AcceptsOrder(order.OrderString);
} }