Fix CA1816

This commit is contained in:
RoosterDragon
2023-03-12 15:59:49 +00:00
committed by abcdefg30
parent a50e72f68d
commit f752e04b03
6 changed files with 8 additions and 5 deletions

View File

@@ -830,6 +830,9 @@ dotnet_diagnostic.CA5351.severity = warning
### Usage Rules
### https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/usage-warnings
# Call GC.SuppressFinalize correctly.
dotnet_diagnostic.CA1816.severity = warning
# Rethrow to preserve stack details.
dotnet_diagnostic.CA2200.severity = warning

View File

@@ -18,7 +18,7 @@ using OpenRA.Primitives;
namespace OpenRA.Graphics
{
public class SpriteCache : IDisposable
public sealed class SpriteCache : IDisposable
{
public readonly Dictionary<SheetType, SheetBuilder> SheetBuilders;
readonly ISpriteLoader[] loaders;

View File

@@ -65,7 +65,7 @@ namespace OpenRA
}
/// <summary>Describes what is to be loaded in order to run a mod.</summary>
public class Manifest : IDisposable
public sealed class Manifest : IDisposable
{
public readonly string Id;
public readonly IReadOnlyPackage Package;

View File

@@ -149,7 +149,7 @@ namespace OpenRA
}
}
public class Map : IReadOnlyFileSystem, IDisposable
public sealed class Map : IReadOnlyFileSystem, IDisposable
{
public const int SupportedMapFormat = 11;
public const int CurrentMapFormat = 12;

View File

@@ -61,7 +61,7 @@ namespace OpenRA
public readonly int mapformat;
}
public class MapPreview : IDisposable, IReadOnlyFileSystem
public sealed class MapPreview : IDisposable, IReadOnlyFileSystem
{
/// <summary>Wrapper that enables map data to be replaced in an atomic fashion.</summary>
sealed class InnerData

View File

@@ -48,7 +48,7 @@ namespace OpenRA.Mods.Cnc.Graphics
}
}
public class VoxelModelCache : IModelCache
public sealed class VoxelModelCache : IModelCache
{
readonly VoxelLoader loader;
readonly Dictionary<string, Dictionary<string, IModel>> models = new();