Fix CA1816
This commit is contained in:
@@ -830,6 +830,9 @@ dotnet_diagnostic.CA5351.severity = warning
|
|||||||
### Usage Rules
|
### Usage Rules
|
||||||
### https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/usage-warnings
|
### https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/usage-warnings
|
||||||
|
|
||||||
|
# Call GC.SuppressFinalize correctly.
|
||||||
|
dotnet_diagnostic.CA1816.severity = warning
|
||||||
|
|
||||||
# Rethrow to preserve stack details.
|
# Rethrow to preserve stack details.
|
||||||
dotnet_diagnostic.CA2200.severity = warning
|
dotnet_diagnostic.CA2200.severity = warning
|
||||||
|
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ using OpenRA.Primitives;
|
|||||||
|
|
||||||
namespace OpenRA.Graphics
|
namespace OpenRA.Graphics
|
||||||
{
|
{
|
||||||
public class SpriteCache : IDisposable
|
public sealed class SpriteCache : IDisposable
|
||||||
{
|
{
|
||||||
public readonly Dictionary<SheetType, SheetBuilder> SheetBuilders;
|
public readonly Dictionary<SheetType, SheetBuilder> SheetBuilders;
|
||||||
readonly ISpriteLoader[] loaders;
|
readonly ISpriteLoader[] loaders;
|
||||||
|
|||||||
@@ -65,7 +65,7 @@ namespace OpenRA
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>Describes what is to be loaded in order to run a mod.</summary>
|
/// <summary>Describes what is to be loaded in order to run a mod.</summary>
|
||||||
public class Manifest : IDisposable
|
public sealed class Manifest : IDisposable
|
||||||
{
|
{
|
||||||
public readonly string Id;
|
public readonly string Id;
|
||||||
public readonly IReadOnlyPackage Package;
|
public readonly IReadOnlyPackage Package;
|
||||||
|
|||||||
@@ -149,7 +149,7 @@ namespace OpenRA
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
public class Map : IReadOnlyFileSystem, IDisposable
|
public sealed class Map : IReadOnlyFileSystem, IDisposable
|
||||||
{
|
{
|
||||||
public const int SupportedMapFormat = 11;
|
public const int SupportedMapFormat = 11;
|
||||||
public const int CurrentMapFormat = 12;
|
public const int CurrentMapFormat = 12;
|
||||||
|
|||||||
@@ -61,7 +61,7 @@ namespace OpenRA
|
|||||||
public readonly int mapformat;
|
public readonly int mapformat;
|
||||||
}
|
}
|
||||||
|
|
||||||
public class MapPreview : IDisposable, IReadOnlyFileSystem
|
public sealed class MapPreview : IDisposable, IReadOnlyFileSystem
|
||||||
{
|
{
|
||||||
/// <summary>Wrapper that enables map data to be replaced in an atomic fashion.</summary>
|
/// <summary>Wrapper that enables map data to be replaced in an atomic fashion.</summary>
|
||||||
sealed class InnerData
|
sealed class InnerData
|
||||||
|
|||||||
@@ -48,7 +48,7 @@ namespace OpenRA.Mods.Cnc.Graphics
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
public class VoxelModelCache : IModelCache
|
public sealed class VoxelModelCache : IModelCache
|
||||||
{
|
{
|
||||||
readonly VoxelLoader loader;
|
readonly VoxelLoader loader;
|
||||||
readonly Dictionary<string, Dictionary<string, IModel>> models = new();
|
readonly Dictionary<string, Dictionary<string, IModel>> models = new();
|
||||||
|
|||||||
Reference in New Issue
Block a user